[ https://issues.apache.org/jira/browse/SCB-498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16444184#comment-16444184 ]
ASF GitHub Bot commented on SCB-498: ------------------------------------ wujimin commented on a change in pull request #651: [SCB-498] Configuration Center ip address need to config default port URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/651#discussion_r182779209 ########## File path: foundations/foundation-common/src/test/java/org/apache/servicecomb/foundation/common/net/TestNetUtils.java ########## @@ -49,6 +49,10 @@ public void testNetutils() { Assert.assertEquals(NetUtils.parseIpPortFromURI(null), null); Assert.assertEquals(NetUtils.parseIpPortFromURI("ss"), null); Assert.assertEquals(NetUtils.parseIpPortFromURI("rest://127.0.0.1:8080").getHostOrIp(), "127.0.0.1"); + Assert.assertEquals(NetUtils.parseIpPortFromURI("http://127.0.0.1:8080").getPort(), 8080); Review comment: expect value is the first parameter ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Configuration Center IP Addresses need to meet general specifications > --------------------------------------------------------------------- > > Key: SCB-498 > URL: https://issues.apache.org/jira/browse/SCB-498 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Java-Chassis > Reporter: WeiChao > Assignee: WeiChao > Priority: Major > > for http/https, the default ports are 80 and 443. if port is not configured, > the default port needs to be used. this simplifies the configuration. -- This message was sent by Atlassian JIRA (v7.6.3#76005)