[
https://issues.apache.org/jira/browse/SCB-482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16445586#comment-16445586
]
ASF GitHub Bot commented on SCB-482:
------------------------------------
Rajadeepan commented on a change in pull request #648: [SCB-482] Http2 support
for java-chassis
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/648#discussion_r183009523
##########
File path:
transports/transport-rest/transport-rest-client/src/main/java/org/apache/servicecomb/transport/rest/client/RestTransportClient.java
##########
@@ -62,7 +77,16 @@ private static HttpClientOptions createHttpClientOptions() {
}
public void send(Invocation invocation, AsyncResponse asyncResp) throws
Exception {
- HttpClientWithContext httpClientWithContext =
clientMgr.findClientPool(invocation.isSync());
+ URIEndpointObject endpoint = (URIEndpointObject)
invocation.getEndpoint().getAddress();
+ HttpClientWithContext httpClientWithContext;
+ if (endpoint.isHttp2Enabled()) {
+ httpClientWithContext =
clientMgrHttp2.findClientPool(invocation.isSync());
+ if (!endpoint.isSslEnabled()) {
+ ((HttpClientImpl)
httpClientWithContext.getHttpClient()).getOptions().setHttp2ClearTextUpgrade(false);
Review comment:
http2 + ssl = h2
http2 + without ssl = h2c
for the http2 client instance to work with h2c the http2ClearTextUpgrade
need to be set to false
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Http2 support for java chassis
> ------------------------------
>
> Key: SCB-482
> URL: https://issues.apache.org/jira/browse/SCB-482
> Project: Apache ServiceComb
> Issue Type: New Feature
> Components: Java-Chassis
> Reporter: Rajadeepan
> Priority: Minor
>
> Http2 support for java chassis.
> Only Application for Rest Vertex and not applicable for servlet and highway.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
