[
https://issues.apache.org/jira/browse/SCB-516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16448283#comment-16448283
]
ASF GitHub Bot commented on SCB-516:
------------------------------------
yhs0092 commented on issue #671: [SCB-516] fix accessLog traceId printing
problem in EdgeService
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/671#issuecomment-383610873
- I’ve modified the Getter in ZipkinProviderDelegate.java to avoid brave's
abandoning the traceId generated by ServiceComb.
- make ServiceComb generate traceId in hexadecimal format as I find that
brave does it like so.
- set access log printing handler in `context.response().endHandler()`
instead of `context.addBodyEndHandler()` because the comment of
`addBodyEndHandler()` says that it may not be invoked.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> AccessLog of EdgeService does not print traceId
> -----------------------------------------------
>
> Key: SCB-516
> URL: https://issues.apache.org/jira/browse/SCB-516
> Project: Apache ServiceComb
> Issue Type: Bug
> Components: Java-Chassis
> Reporter: YaoHaishi
> Assignee: YaoHaishi
> Priority: Major
> Attachments: ComplieWarning.PNG
>
>
> The access log of EdgeService always prints "-" as traceId.
> It's found out that in TraceIdItem, traceId cannot be gotten, because the
> dispatcher of EdgeService does not always set invocation into RoutingContext
> like the VertxRestDispatcher.onRequest() does.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
