[
https://issues.apache.org/jira/browse/SCB-518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16453429#comment-16453429
]
ASF GitHub Bot commented on SCB-518:
------------------------------------
liubao68 commented on a change in pull request #676: [SCB-518] ServiceCenter ip
address need to config default port
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/676#discussion_r184260114
##########
File path:
service-registry/src/main/java/org/apache/servicecomb/serviceregistry/config/ServiceRegistryConfig.java
##########
@@ -133,10 +131,8 @@ public boolean isSsl() {
uriList.forEach(anUriList -> {
try {
URI uri = new URI(anUriList);
- StringBuilder sb = new StringBuilder(uri.getHost());
- sb.append(':').append(uri.getPort() < 0 ? PROTOCOL_HTTP_PORT :
uri.getPort());
this.ssl = uri.getScheme().startsWith("https");
Review comment:
I think it's better use "https" equals uri.getScheme
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> ServiceCenter ip address need to config default port
> ----------------------------------------------------
>
> Key: SCB-518
> URL: https://issues.apache.org/jira/browse/SCB-518
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Java-Chassis
> Reporter: WeiChao
> Assignee: WeiChao
> Priority: Major
>
> for http/https, the default ports are 80 and 443. if port is not configured,
> the default port needs to be used. this simplifies the configuration.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
