[
https://issues.apache.org/jira/browse/SCB-440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16456001#comment-16456001
]
ASF GitHub Bot commented on SCB-440:
------------------------------------
wujimin commented on a change in pull request #674: [SCB-440] Provide Maven
Archetype of business-service-pojo
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/674#discussion_r184604465
##########
File path:
archetypes/business-service-pojo/src/main/java/org/apache/servicecomb/archetypes/HelloEndpoint.java
##########
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.archetypes;
+
+import org.apache.servicecomb.provider.pojo.RpcSchema;
+
+@RpcSchema(schemaId = "helloEndpoint")
+public class HelloEndpoint implements Hello {
Review comment:
names "Endpoint" is not so good.
conflict with transport endpoint.
Schema is important in ServiceComb, do not bypass it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Provide Maven Archetype of business-service-pojo
> ------------------------------------------------
>
> Key: SCB-440
> URL: https://issues.apache.org/jira/browse/SCB-440
> Project: Apache ServiceComb
> Issue Type: Sub-task
> Components: Java-Chassis
> Affects Versions: java-chassis-1.0.0-m2
> Reporter: yangyongzheng
> Assignee: yangyongzheng
> Priority: Major
> Fix For: java-chassis-1.0.0-m2
>
>
> This Archetype for create a common microservice using pojo provider.
> It's contains :
> 1.All necessary dependencies in pom.
> 2.An HelloEndpoint provider using pojo mode.
> 3.Default microservice.yaml.
> 4.Provider bean xml Included spring component-scan.
> 5.Consumer in test and can direct run with local registry.
> 6.Readme file teach user what can be done further.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
