[
https://issues.apache.org/jira/browse/SCB-526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16457495#comment-16457495
]
ASF GitHub Bot commented on SCB-526:
------------------------------------
WillemJiang commented on a change in pull request #681: [SCB-526]fetch once
from dynamic config source when boot up
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/681#discussion_r184847776
##########
File path:
dynamic-config/config-cc/src/main/java/org/apache/servicecomb/config/client/ConfigCenterClient.java
##########
@@ -155,8 +161,19 @@ private void refreshMembers(MemberDiscovery
memberDiscovery) {
request.headers().add("X-Auth-Token",
ConfigCenterConfig.INSTANCE.getToken());
}
authHeaderProviders.forEach(provider ->
request.headers().addAll(provider.getSignAuthHeaders(signReq)));
+ request.exceptionHandler(e -> {
+ LOGGER.error("Fetch member from {} failed. Error message is [{}].",
configCenter, e.getMessage());
+ latch.countDown();
+ });
request.end();
});
+ if (wait) {
+ try {
Review comment:
Write a log for the waiting could be a good way to go.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> When creating dynamic configuration, we need to fetch once for the
> configuration when startup
> ---------------------------------------------------------------------------------------------
>
> Key: SCB-526
> URL: https://issues.apache.org/jira/browse/SCB-526
> Project: Apache ServiceComb
> Issue Type: Improvement
> Reporter: liubao
> Assignee: liubao
> Priority: Major
>
> Currently, dynamic config is fetched asynchronously, and when users use
> dynamic configuration for following scenario will fail:
> # make some environment, e.g. credentials
> # spring @Value mechanism
> and so on.
>
> When users put these configurations to some dynamic configuration server,
> they can assume server is running OK, and if try to fetch will give the
> correct response.
>
> So it's very useful to fetch configurations once when boot up.
>
>
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
