[ 
https://issues.apache.org/jira/browse/SCB-506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16461162#comment-16461162
 ] 

ASF GitHub Bot commented on SCB-506:
------------------------------------

wujimin commented on a change in pull request #678: [SCB-506]服务治理相关的需要事件上报
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/678#discussion_r185535372
 
 

 ##########
 File path: 
handlers/handler-bizkeeper/src/main/java/org/apache/servicecomb/bizkeeper/BizkeeperHandler.java
 ##########
 @@ -82,6 +92,25 @@ public void handle(Invocation invocation, AsyncResponse 
asyncResp) {
     });
   }
 
+  /**
+   * 使用circuitMarker来记录被熔断的接口
+   * 判断熔断开启或关闭,如果之前没有发送过告警信息才会发送告警
+   */
+  private void eventAlarm(Invocation invocation) {
+    HystrixCommandKey commandKey = CommandKey.toHystrixCommandKey(groupname, 
invocation);
+    HystrixCircuitBreaker circuitBreaker =
+        HystrixCircuitBreaker.Factory.getInstance(commandKey);
+    String microserviceQualifiedName = 
invocation.getMicroserviceQualifiedName();
+    if (circuitBreaker != null && circuitBreaker.isOpen() && 
circuitMarker.get(microserviceQualifiedName) == null) {
+      EventManager.post(new CircutBreakerEvent(invocation, commandKey, 
this.groupname, Type.OPEN));
 
 Review comment:
   requirement is want to know the even that some one invocation is broken
   or break flag change from one to another
   or both?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> 服务治理相关的需要事件上报
> -------------
>
>                 Key: SCB-506
>                 URL: https://issues.apache.org/jira/browse/SCB-506
>             Project: Apache ServiceComb
>          Issue Type: Task
>          Components: Java-Chassis
>            Reporter: xuyiyun
>            Assignee: xuyiyun
>            Priority: Major
>             Fix For: java-chassis-1.0.0-m2
>
>
> 如果发生服务降级 实例隔离 熔断等操作,业务监控系统需要能获取到对应的通知,方便集成



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to