[
https://issues.apache.org/jira/browse/SCB-546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16466991#comment-16466991
]
ASF GitHub Bot commented on SCB-546:
------------------------------------
wujimin commented on a change in pull request #691: [SCB-546] refactor the
schemas registry logic
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/691#discussion_r186636150
##########
File path:
service-registry/src/main/java/org/apache/servicecomb/serviceregistry/task/MicroserviceRegisterTask.java
##########
@@ -136,19 +140,48 @@ private boolean checkSchemaIdSet() {
}
private boolean registerSchemas() {
+ List<GetSchemaResponse> existSchemas =
srClient.getSchemas(microservice.getServiceId());
for (Entry<String, String> entry : microservice.getSchemaMap().entrySet())
{
String schemaId = entry.getKey();
String content = entry.getValue();
-
- boolean exists = srClient.isSchemaExist(microservice.getServiceId(),
schemaId);
- LOGGER.info("schemaId {} exists {}", schemaId, exists);
+ GetSchemaResponse existSchema = extractSchema(schemaId, existSchemas);
+ boolean exists = existSchema == null ? false : true;
+ LOGGER.info("schemaId [{}] exists {}", schemaId, exists);
if (!exists) {
if (!srClient.registerSchema(microservice.getServiceId(), schemaId,
content)) {
return false;
}
+ } else {
+ String curSchemaSumary = existSchema.getSummary();
+ String schemaSummary = Hashing.md5().newHasher().putString(content,
Charsets.UTF_8).hash().toString();
+ if (!schemaSummary.equals(curSchemaSumary)) {
+ if (microservice.getInstance().getEnvironment().startsWith("dev")) {
+ LOGGER.info(
+ "schemaId [{}]'s content changes and the current enviroment is
development, so re-register it!",
+ schemaId);
+ srClient.registerSchema(microservice.getServiceId(), schemaId,
content);
Review comment:
if falsed then will return true?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> As a developer, want to reregistry schemas in the dev environment
> -----------------------------------------------------------------
>
> Key: SCB-546
> URL: https://issues.apache.org/jira/browse/SCB-546
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Java-Chassis
> Affects Versions: java-chassis-1.0.0-m1
> Reporter: jeho0815
> Assignee: jeho0815
> Priority: Major
> Fix For: java-chassis-1.0.0-m2
>
>
> 1、the servicecenter has a new rest interface which return all schemas with
> signature, so we can compare the summary to know whether to update the schema
> 2、if the instance enviroment is dev, we reregistry the schemas, otherwize
> throw a RuntimeException to avoid make some potential exception in production
> environment
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
