[
https://issues.apache.org/jira/browse/SCB-543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16470111#comment-16470111
]
ASF GitHub Bot commented on SCB-543:
------------------------------------
liubao68 closed pull request #692: [SCB-543]optimize registry procedure
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/692
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/service-registry/src/main/java/org/apache/servicecomb/serviceregistry/task/MicroserviceInstanceRegisterTask.java
b/service-registry/src/main/java/org/apache/servicecomb/serviceregistry/task/MicroserviceInstanceRegisterTask.java
index 37039b059..f0132b635 100644
---
a/service-registry/src/main/java/org/apache/servicecomb/serviceregistry/task/MicroserviceInstanceRegisterTask.java
+++
b/service-registry/src/main/java/org/apache/servicecomb/serviceregistry/task/MicroserviceInstanceRegisterTask.java
@@ -69,7 +69,7 @@ protected boolean doRegister() {
String instanceId =
srClient.registerMicroserviceInstance(microserviceInstance);
if (StringUtils.isEmpty(instanceId)) {
- LOGGER.error("Register microservice instance failed. microserviceId={}",
+ LOGGER.error("Register microservice instance failed,will back to
register microservice again. microserviceId={}",
microserviceInstance.getServiceId());
return false;
}
diff --git
a/service-registry/src/main/java/org/apache/servicecomb/serviceregistry/task/MicroserviceRegisterTask.java
b/service-registry/src/main/java/org/apache/servicecomb/serviceregistry/task/MicroserviceRegisterTask.java
index b029d6277..905c34bff 100644
---
a/service-registry/src/main/java/org/apache/servicecomb/serviceregistry/task/MicroserviceRegisterTask.java
+++
b/service-registry/src/main/java/org/apache/servicecomb/serviceregistry/task/MicroserviceRegisterTask.java
@@ -52,6 +52,15 @@ public void
onMicroserviceInstanceHeartbeatTask(MicroserviceInstanceHeartbeatTas
}
}
+ @Subscribe
+ public void onInstanceRegistryFailed(MicroserviceInstanceRegisterTask task) {
+ if (task.taskStatus != TaskStatus.FINISHED){
+ LOGGER.info("read MicroserviceInstanceRegisterTask status is {}",
task.taskStatus);
+ this.taskStatus = TaskStatus.READY;
+ this.registered = false;
+ }
+ }
+
@Override
protected boolean doRegister() {
LOGGER.info("running microservice register task.");
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> optimize registry procedure
> ---------------------------
>
> Key: SCB-543
> URL: https://issues.apache.org/jira/browse/SCB-543
> Project: Apache ServiceComb
> Issue Type: Improvement
> Reporter: TaoMeng
> Assignee: TaoMeng
> Priority: Major
>
> In one case of csp upgrade scene 1: successfully registry microsevice at
> first , 2: then delete the microservice static information but instance is
> still registrying , the result is registry instance in hanging on because sc
> has no microservice static information.so in order to optimize this registry
> halt , i put registry instance procedure to registry microservice again
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
