[
https://issues.apache.org/jira/browse/SCB-546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16470216#comment-16470216
]
ASF GitHub Bot commented on SCB-546:
------------------------------------
jeho0815 commented on a change in pull request #698: [SCB-546] bug fix
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/698#discussion_r187299590
##########
File path:
service-registry/src/main/java/org/apache/servicecomb/serviceregistry/task/MicroserviceRegisterTask.java
##########
@@ -155,7 +155,7 @@ private boolean registerSchemas() {
String curSchemaSumary = existSchema.getSummary();
String schemaSummary = Hashing.sha256().newHasher().putString(content,
Charsets.UTF_8).hash().toString();
if (!schemaSummary.equals(curSchemaSumary)) {
- if
(microservice.getInstance().getEnvironment().equalsIgnoreCase("development")) {
+ if (curSchemaSumary == null ||
microservice.getInstance().getEnvironment().equalsIgnoreCase("development")) {
Review comment:
1、has changed, but old version' summary content is null too, may has some
potential problem
2、local impl work well, because it generate one list on startup
3、i don't know why CI can't check this error out. will check go on
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> As a developer, want to reregistry schemas in the dev environment
> -----------------------------------------------------------------
>
> Key: SCB-546
> URL: https://issues.apache.org/jira/browse/SCB-546
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Java-Chassis
> Affects Versions: java-chassis-1.0.0-m1
> Reporter: jeho0815
> Assignee: jeho0815
> Priority: Major
> Fix For: java-chassis-1.0.0-m2
>
>
> 1、the servicecenter has a new rest interface which return all schemas with
> signature, so we can compare the summary to know whether to update the schema
> 2、if the instance enviroment is dev, we reregistry the schemas, otherwize
> throw a RuntimeException to avoid make some potential exception in production
> environment
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
