[
https://issues.apache.org/jira/browse/SCB-548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16473703#comment-16473703
]
ASF GitHub Bot commented on SCB-548:
------------------------------------
liubao68 commented on a change in pull request #693: [SCB-548] support
gracefully shutdown
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/693#discussion_r187825075
##########
File path:
core/src/main/java/org/apache/servicecomb/core/handler/ShutdownHookHandler.java
##########
@@ -39,13 +40,16 @@
private final AtomicLong responseCounter = new AtomicLong(0);
- private final int timeout = 600;
-
- private final int period = 10;
-
private volatile boolean shuttingDown = false;
+ public final Semaphore ALL_INVOCATION_FINISHED = new Semaphore(1);
+
private ShutdownHookHandler() {
+ try {
+ ALL_INVOCATION_FINISHED.acquire();
Review comment:
I think it's better to make semaphore private and add a method like
waitInvocationFinish. And in initialization, acquire is not required and
shutdownhook can be removed too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Support Gracefully Shutdown
> ---------------------------
>
> Key: SCB-548
> URL: https://issues.apache.org/jira/browse/SCB-548
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Java-Chassis
> Affects Versions: java-chassis-1.0.0-m2
> Reporter: yangyongzheng
> Assignee: yangyongzheng
> Priority: Major
>
> We did not implement gracefully shutdown yet:
> ```java
> // 当程序退出时，进行相关清理，注意：kill -9 {pid}下无效
> // 1. 去注册实例信息
> // TODO 服务优雅退出
> if (applicationContext instanceof AbstractApplicationContext) {
> ((AbstractApplicationContext)
> applicationContext).registerShutdownHook();
> }
> ```
>
> And had got an issue :
> https://github.com/apache/incubator-servicecomb-java-chassis/issues/685 from
> user.
> So it's time we must do it and remove this TODO
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
