[
https://issues.apache.org/jira/browse/SCB-532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16474007#comment-16474007
]
ASF GitHub Bot commented on SCB-532:
------------------------------------
WillemJiang commented on a change in pull request #699: [SCB-532] Support
recursive dependency
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/699#discussion_r187901718
##########
File path:
common/common-javassist/src/main/java/org/apache/servicecomb/common/javassist/JavassistUtils.java
##########
@@ -185,10 +185,47 @@ private static void addEnumValuesMethod(CtClass ctClass,
List<String> values) th
}
}
- LOGGER.info("generate {} in classLoader {}.", config.getClassName(),
classLoader);
- return ctClass.toClass(classLoader, null);
+ LOGGER.info("create CtClass {} in classLoader {}.",
config.getClassName(), classLoader);
+ return ctClass;
+ } catch (Throwable e) {
+ throw new IllegalStateException(
+ String.format("Failed to create CtClass %s in classLoader %s.",
config.getClassName(),
+ classLoader), e);
+ }
+ }
+
+ public static Class<?> createClass(ClassLoader classLoader, ClassConfig
config) {
+ if (classLoader == null) {
Review comment:
oh, my suggestion is not print the exception here , it just write some log
message for switching the classloader to thread context classloader.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> support recursive dependence
> ----------------------------
>
> Key: SCB-532
> URL: https://issues.apache.org/jira/browse/SCB-532
> Project: Apache ServiceComb
> Issue Type: Sub-task
> Components: Java-Chassis
> Reporter: wujimin
> Assignee: wujimin
> Priority: Major
> Fix For: java-chassis-1.0.0-m2
>
>
> {code:java}
> 1.class A{
> A a;
> }
> 2.class A{
> B b;
> }
> class B{
> A a;
> }{code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
