[
https://issues.apache.org/jira/browse/SCB-575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16490486#comment-16490486
]
ASF GitHub Bot commented on SCB-575:
------------------------------------
WillemJiang closed pull request #723: [SCB-575] Fix doc comments for generating
java doc
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/723
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/handlers/handler-fault-injection/src/main/java/org/apache/servicecomb/faultinjection/FaultInjectionUtil.java
b/handlers/handler-fault-injection/src/main/java/org/apache/servicecomb/faultinjection/FaultInjectionUtil.java
index 0b30dfe2c..57d77289b 100755
---
a/handlers/handler-fault-injection/src/main/java/org/apache/servicecomb/faultinjection/FaultInjectionUtil.java
+++
b/handlers/handler-fault-injection/src/main/java/org/apache/servicecomb/faultinjection/FaultInjectionUtil.java
@@ -140,7 +140,6 @@ private static int getConfigValue(String config) {
*
* @param reqCount
* @param percentage
- * @param key
* @return true: delay/abort is needed. false: delay/abort is not needed.
*/
public static boolean isFaultNeedToInject(long reqCount, int percentage) {
diff --git
a/handlers/handler-flowcontrol-qps/src/main/java/org/apache/servicecomb/qps/QpsControllerManager.java
b/handlers/handler-flowcontrol-qps/src/main/java/org/apache/servicecomb/qps/QpsControllerManager.java
index 216a797c3..d637e1f78 100644
---
a/handlers/handler-flowcontrol-qps/src/main/java/org/apache/servicecomb/qps/QpsControllerManager.java
+++
b/handlers/handler-flowcontrol-qps/src/main/java/org/apache/servicecomb/qps/QpsControllerManager.java
@@ -74,7 +74,7 @@ protected QpsController create(String qualifiedNameKey,
String microserviceName,
* Firstly try to search "microservice.schema.operation". If no valid result
found, then try "microservice.schema",
* and then "microservice" or global qpsController(If there is a global
qpsController).</p>
* <p> This method ensures that there is always an existing qpsController
returned, as the relevant qpsController has
- * been created and stored in {@link #create(String)}</p>
+ * been created and stored in {@link #create(String, String, Invocation)}</p>
*
* @param qualifiedNameKey qualifiedNameKey in {@link
#qualifiedNameControllerMap}
* @return a qps controller, lower level controllers with valid qpsLimit
have priority.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Publish the Java doc of ServiceComb projects
> --------------------------------------------
>
> Key: SCB-575
> URL: https://issues.apache.org/jira/browse/SCB-575
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Java-Chassis, Saga
> Reporter: Willem Jiang
> Assignee: Yang Bo
> Priority: Major
> Fix For: java-chassis-1.0.0-m2, saga-0.2.0
>
>
> We should generate the API document and publish it to the website.
> * Aggregate the java doc
> * Submit the generated pages to ServiceComb website.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
