[
https://issues.apache.org/jira/browse/SCB-617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16496004#comment-16496004
]
ASF GitHub Bot commented on SCB-617:
------------------------------------
WillemJiang commented on a change in pull request #731: [SCB-617] Graceful
shutdown with standalone tomcat
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/731#discussion_r191976128
##########
File path:
core/src/main/java/org/apache/servicecomb/core/executor/FixedThreadExecutor.java
##########
@@ -74,4 +76,11 @@ private Executor chooseExecutor(long threadId) {
int idx = index.getAndIncrement() % executorList.size();
return executorList.get(idx);
}
+
+ @Override
+ public void close() {
+ for (ExecutorService executorService : executorList) {
+ executorService.shutdown();
+ }
+ }
Review comment:
Do we need to clear the excutorList?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> graceful shutdown with standalone tomcat
> ----------------------------------------
>
> Key: SCB-617
> URL: https://issues.apache.org/jira/browse/SCB-617
> Project: Apache ServiceComb
> Issue Type: Bug
> Components: Java-Chassis
> Reporter: wujimin
> Assignee: wujimin
> Priority: Major
> Fix For: java-chassis-1.0.0-m2
>
>
> standalone tomcat shutdown by receive shutdown command from shutdown port
> after everything prepared, then do real shutdown action, so our shutdown hook
> will not be invoked.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
