[
https://issues.apache.org/jira/browse/SCB-667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16512040#comment-16512040
]
ASF GitHub Bot commented on SCB-667:
------------------------------------
wujimin commented on a change in pull request #769: [SCB-667] fix gracefully
shutdown is not work in some case
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/769#discussion_r195315524
##########
File path:
common/common-rest/src/main/java/org/apache/servicecomb/common/rest/AbstractRestInvocation.java
##########
@@ -160,16 +163,24 @@ public void invoke() {
}
protected Response prepareInvoke() throws Throwable {
- this.initProduceProcessor();
+ SCBStatus currentStatus = SCBEngine.getInstance().getStatus();
Review comment:
why not just invoke ensureStatusUp, or refactor ensureStatusUp, so that no
need to write the error message everywhere
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> gracefully shutdown is not work in some case
> --------------------------------------------
>
> Key: SCB-667
> URL: https://issues.apache.org/jira/browse/SCB-667
> Project: Apache ServiceComb
> Issue Type: Bug
> Components: Java-Chassis
> Affects Versions: java-chassis-1.0.0-m1
> Reporter: yangyongzheng
> Assignee: yangyongzheng
> Priority: Major
> Fix For: java-chassis-1.0.0-m2
>
>
> In some case like consumer never stop sending request to prodiver, privider
> do not reject new request from consumer and still process them,
> So shutdown will be blocked.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
