[ 
https://issues.apache.org/jira/browse/SCB-630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16512455#comment-16512455
 ] 

ASF GitHub Bot commented on SCB-630:
------------------------------------

coveralls commented on issue #209: SCB-630 Active the -Pdocker profile if 
detect the docker installation
URL: 
https://github.com/apache/incubator-servicecomb-saga/pull/209#issuecomment-397293759
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/17490552/badge)](https://coveralls.io/builds/17490552)
   
   Coverage decreased (-0.6%) to 94.02% when pulling 
**01cacf2a088bda19ad2eb66a1dbbcf913ef99b6a on SingleX:SCB-630** into 
**55aba24805c1f9db1d6eeb7090b483c1522e3826 on apache:master**.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Active the -Pdocker profile if detect the docker installation 
> --------------------------------------------------------------
>
>                 Key: SCB-630
>                 URL: https://issues.apache.org/jira/browse/SCB-630
>             Project: Apache ServiceComb
>          Issue Type: Improvement
>          Components: Saga
>            Reporter: Willem Jiang
>            Assignee: Gao Xin
>            Priority: Major
>              Labels: easyfix, newbie
>             Fix For: saga-0.3.0
>
>
> Currently we use the -Pdocker to use the docker enabled feature to avoid the 
> build failure if there is no docker installation.
> Now we can use the maven [profile with 
> activation|https://books.sonatype.com/mvnref-book/reference/profiles-sect-activation.html]
>  to enable the docker profile automatically.
> {code}
>      <activation>
>         <file>
>           <exists>/var/run/docker.sock</exists>
>         </file>
>         <property>
>           <name>env.DOCKER_HOST</name>
>         </property>
>       </activation>
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to