[ https://issues.apache.org/jira/browse/SCB-679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16519263#comment-16519263 ]
ASF GitHub Bot commented on SCB-679: ------------------------------------ yhs0092 commented on a change in pull request #771: [SCB-679] Support Cross-Origin Resource Sharing (CORS) URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/771#discussion_r197104800 ########## File path: service-registry/src/main/java/org/apache/servicecomb/serviceregistry/task/MicroserviceRegisterTask.java ########## @@ -307,7 +307,10 @@ private void checkRemainingSchema(Map<String, GetSchemaResponse> scSchemaMap) { // Currently nothing to do but print a warning LOGGER.warn("There are schemas only existing in service center: {}, which means there are interfaces changed. " - + "It's recommended to increment microservice version before deploying.", scSchemaMap.keySet()); + + "It's recommended to increment microservice version before deploying.", + scSchemaMap.keySet()); + LOGGER.warn("ATTENTION: The schemas in new version are less than the old version, " Review comment: This is for the review opinion in another [PR-757](https://github.com/apache/incubator-servicecomb-java-chassis/pull/757). I need to warn users to take care of compatibility issues. I don't know how to describe it clearer with my poor English :P ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Support Cross-Origin Resource Sharing (CORS) > -------------------------------------------- > > Key: SCB-679 > URL: https://issues.apache.org/jira/browse/SCB-679 > Project: Apache ServiceComb > Issue Type: New Feature > Components: Java-Chassis > Affects Versions: Java-chassis-1.0.0 > Reporter: YaoHaishi > Assignee: YaoHaishi > Priority: Major > > Provide configurations to let user mount and config Vert.x CorsHandler. -- This message was sent by Atlassian JIRA (v7.6.3#76005)