[ 
https://issues.apache.org/jira/browse/SCB-687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16550317#comment-16550317
 ] 

ASF GitHub Bot commented on SCB-687:
------------------------------------

zhengyangyong commented on a change in pull request #824: [SCB-687] add highway 
server connection protection
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/824#discussion_r203955004
 
 

 ##########
 File path: 
integration-tests/spring-pojo-tests/src/test/java/org/apache/servicecomb/demo/pojo/test/ConnectionEventWatcher.java
 ##########
 @@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.demo.pojo.test;
+
+import java.util.ArrayList;
+import java.util.List;
+
+import org.apache.servicecomb.foundation.vertx.ClientClosedEvent;
+import org.apache.servicecomb.foundation.vertx.ClientConnectedEvent;
+
+import com.google.common.eventbus.Subscribe;
+
+public class ConnectionEventWatcher {
+  private final List<Integer> counters = new ArrayList<>();
+
+  public List<Integer> getCounters() {
+    return counters;
+  }
+
+  @Subscribe
 
 Review comment:
   only for test
   ```java
   Assert.assertArrayEquals("check connection count change", new Integer[] {1, 
0}, watcher.getCounters().toArray());
   ```
   watcher will receive a connection connected event when consumer calling
   event.getTotalConnectedCount() = 1
   and when 
   ```java
   SCBEngine.getInstance().destroy();
   ```
   watcher will receive a connection close event
   event.getTotalConnectedCount() = 0
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> highway server not accept too many connection
> ---------------------------------------------
>
>                 Key: SCB-687
>                 URL: https://issues.apache.org/jira/browse/SCB-687
>             Project: Apache ServiceComb
>          Issue Type: Sub-task
>          Components: Java-Chassis
>            Reporter: wujimin
>            Assignee: yangyongzheng
>            Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to