[ https://issues.apache.org/jira/browse/SCB-840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16579455#comment-16579455 ]
ASF GitHub Bot commented on SCB-840: ------------------------------------ codecov-io edited a comment on issue #414: SCB-840 Support configable limit in buildin quota plugin URL: https://github.com/apache/incubator-servicecomb-service-center/pull/414#issuecomment-412769332 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/414?src=pr&el=h1) Report > Merging [#414](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/414?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/447a47ad72afbcca2c175701bd8d57cb068b734d?src=pr&el=desc) will **increase** coverage by `0.02%`. > The diff coverage is `100%`. [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/414/graphs/tree.svg?src=pr&token=GAaF7zrg8R&width=650&height=150)](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/414?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #414 +/- ## ========================================== + Coverage 73.2% 73.23% +0.02% ========================================== Files 124 124 Lines 9917 9926 +9 ========================================== + Hits 7260 7269 +9 + Misses 2180 2178 -2 - Partials 477 479 +2 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/414?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [pkg/util/sys.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/414/diff?src=pr&el=tree#diff-cGtnL3V0aWwvc3lzLmdv) | `92% <100%> (+4.5%)` | :arrow_up: | | [server/service/notification/stream.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/414/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2Uvbm90aWZpY2F0aW9uL3N0cmVhbS5nbw==) | `65.21% <0%> (-4.35%)` | :arrow_down: | | [server/govern/service.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/414/diff?src=pr&el=tree#diff-c2VydmVyL2dvdmVybi9zZXJ2aWNlLmdv) | `73.33% <0%> (-0.34%)` | :arrow_down: | | [server/broker/util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/414/diff?src=pr&el=tree#diff-c2VydmVyL2Jyb2tlci91dGlsLmdv) | `53.33% <0%> (-0.27%)` | :arrow_down: | | [server/plugin/infra/registry/etcd/etcd.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/414/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9pbmZyYS9yZWdpc3RyeS9ldGNkL2V0Y2QuZ28=) | `86.04% <0%> (-0.2%)` | :arrow_down: | | [server/service/notification/websocket.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/414/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2Uvbm90aWZpY2F0aW9uL3dlYnNvY2tldC5nbw==) | `84.51% <0%> (+0.64%)` | :arrow_up: | | [pkg/util/log.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/414/diff?src=pr&el=tree#diff-cGtnL3V0aWwvbG9nLmdv) | `75.4% <0%> (+1.63%)` | :arrow_up: | | [server/plugin/infra/registry/etcd/tracing.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/414/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9pbmZyYS9yZWdpc3RyeS9ldGNkL3RyYWNpbmcuZ28=) | `81.81% <0%> (+9.09%)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/414?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/414?src=pr&el=footer). Last update [447a47a...f375b5b](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/414?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Support configable limit in buildin quota plugin > ------------------------------------------------ > > Key: SCB-840 > URL: https://issues.apache.org/jira/browse/SCB-840 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Service-Center > Reporter: little-cui > Assignee: little-cui > Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)