[ https://issues.apache.org/jira/browse/SCB-860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16597025#comment-16597025 ]
ASF GitHub Bot commented on SCB-860: ------------------------------------ wujimin commented on issue #880: [SCB-860] Optimize microservice register process, abort registry when query microservice id fails URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/880#issuecomment-417180478 discussed no need to do this change, just close it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Optimize microservice register process, abort registry when query > microservice id fails > --------------------------------------------------------------------------------------- > > Key: SCB-860 > URL: https://issues.apache.org/jira/browse/SCB-860 > Project: Apache ServiceComb > Issue Type: Improvement > Reporter: YaoHaishi > Assignee: YaoHaishi > Priority: Minor > > Currently if the microservice id query fails or microservice does not exist, > the sc client will return null, and MicroserviceRegisterTask cannot > distinguish these situation. As a result, even though query fails, > MicroserviceRegisterTask will go on to the next logic, which will cause > unnecessary net work load. > We need to make sc client return more detailed microservice id query result, > and abort registry process when query fails. -- This message was sent by Atlassian JIRA (v7.6.3#76005)