[
https://issues.apache.org/jira/browse/SCB-877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16614402#comment-16614402
]
ASF GitHub Bot commented on SCB-877:
------------------------------------
WillemJiang commented on a change in pull request #295: SCB-877 persisted the
received TCC events
URL:
https://github.com/apache/incubator-servicecomb-saga/pull/295#discussion_r217607228
##########
File path:
alpha/alpha-server/src/test/java/org/apache/servicecomb/saga/alpha/tcc/server/MemoryAlphaTccServerTest.java
##########
@@ -0,0 +1,93 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.saga.alpha.tcc.server;
+
+import io.grpc.netty.NettyChannelBuilder;
+import org.apache.servicecomb.saga.alpha.server.AlphaApplication;
+import org.apache.servicecomb.saga.alpha.server.tcc.TccTxEventFacade;
+import org.junit.BeforeClass;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.beans.factory.annotation.Qualifier;
+import org.springframework.boot.test.context.SpringBootTest;
+import org.springframework.test.context.junit4.SpringRunner;
+
+@RunWith(SpringRunner.class)
+@SpringBootTest(classes = {AlphaApplication.class},
+ properties = {
+ "alpha.server.host=0.0.0.0",
+ "alpha.server.port=8090",
+ "alpha.server.storage=local"
+ })
+public class MemoryAlphaTccServerTest extends AlphaTccServerTest {
+
+ @BeforeClass
+ public static void setupClientChannel() {
+ clientChannel = NettyChannelBuilder.forAddress("localhost",
8090).usePlaintext().build();
+ }
+
+ @Autowired
+ @Qualifier("defaultTccTxEventFacade")
+ private TccTxEventFacade tccTxEventFacade;
+
+ @Override
+ public TccTxEventFacade getTccTxEventFacade() {
+ return tccTxEventFacade;
+ }
+
+ @Test
Review comment:
The Test annotation can still be there and we just need to rename
AlphaTccServerTest to AlphaTccServerTestBase
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Alpha should pesistend the received TCC events
> -------------------------------------------------
>
> Key: SCB-877
> URL: https://issues.apache.org/jira/browse/SCB-877
> Project: Apache ServiceComb
> Issue Type: Sub-task
> Reporter: Willem Jiang
> Assignee: cherrylzhao
> Priority: Major
> Fix For: saga-0.3.0
>
>
> It's important that we need to keep all the received the TCC events
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
