[
https://issues.apache.org/jira/browse/SCB-911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16614495#comment-16614495
]
ASF GitHub Bot commented on SCB-911:
------------------------------------
liubao68 commented on a change in pull request #907: [SCB-911]Timeout scenario
print too many logs
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/907#discussion_r217630845
##########
File path:
swagger/swagger-invocation/invocation-core/src/main/java/org/apache/servicecomb/swagger/invocation/exception/ExceptionToResponseConverters.java
##########
@@ -42,8 +44,18 @@ public ExceptionToResponseConverters() {
}
public Response convertExceptionToResponse(SwaggerInvocation
swaggerInvocation, Throwable e) {
- ExceptionToResponseConverter<Throwable> converter =
- exceptionToResponseConverters.getOrDefault(e.getClass(),
defaultConverter);
+ ExceptionToResponseConverter<Throwable> converter = null;
Review comment:
It will not improve a lot of performance for doing that. Because class
hierarchy will not be that high, 3 is most of the case. Caching too many keys
may get worse performance when map entry grows. And error processing is not
that performance critical.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Timeout scenario print too many logs
> ------------------------------------
>
> Key: SCB-911
> URL: https://issues.apache.org/jira/browse/SCB-911
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Java-Chassis
> Reporter: liubao
> Assignee: liubao
> Priority: Major
>
> In some scenario, timeout is very normal. customers do not want print too
> much logs in this situation.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
