[
https://issues.apache.org/jira/browse/SCB-932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16623028#comment-16623028
]
ASF GitHub Bot commented on SCB-932:
------------------------------------
wujimin commented on a change in pull request #919: [SCB-932]Time jump cause
the new request injected
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/919#discussion_r219376212
##########
File path:
handlers/handler-flowcontrol-qps/src/main/java/org/apache/servicecomb/qps/QpsController.java
##########
@@ -57,7 +57,8 @@ public void setQpsLimit(Integer qpsLimit) {
public boolean isLimitNewRequest() {
long newCount = requestCount.incrementAndGet();
long msNow = System.currentTimeMillis();
- if (msNow - msCycleBegin > CYCLE_LENGTH) {
+ //时间跳变(9/21->9/20)会导致本不该拒绝的请求被拒绝
Review comment:
new code comments better to be english
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Time jump cause the new request injected
> ----------------------------------------
>
> Key: SCB-932
> URL: https://issues.apache.org/jira/browse/SCB-932
> Project: Apache ServiceComb
> Issue Type: Task
> Reporter: laijianbin
> Assignee: laijianbin
> Priority: Major
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
