[
https://issues.apache.org/jira/browse/SCB-937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16626741#comment-16626741
] ASF GitHub Bot commented on SCB-937: ------------------------------------ codecov-io commented on issue #449: SCB-937 Customizable tracing sample rate URL: https://github.com/apache/incubator-servicecomb-service-center/pull/449#issuecomment-424200199 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/449?src=pr&el=h1) Report > Merging [#449](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/449?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/95013d48d6c3db50c10f575a29d0b773fb9c4128?src=pr&el=desc) will **increase** coverage by `0.22%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/449?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #449 +/- ## ========================================== + Coverage 59.77% 59.99% +0.22% ========================================== Files 149 149 Lines 13174 13182 +8 ========================================== + Hits 7875 7909 +34 + Misses 4727 4703 -24 + Partials 572 570 -2 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/449?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [server/plugin/infra/tracing/buildin/common.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/449/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9pbmZyYS90cmFjaW5nL2J1aWxkaW4vY29tbW9uLmdv) | `80% <100%> (+30%)` | :arrow_up: | | [server/plugin/infra/registry/etcd/tracing.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/449/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9pbmZyYS9yZWdpc3RyeS9ldGNkL3RyYWNpbmcuZ28=) | `72.72% <0%> (-9.1%)` | :arrow_down: | | [server/plugin/infra/registry/etcd/etcd.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/449/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9pbmZyYS9yZWdpc3RyeS9ldGNkL2V0Y2QuZ28=) | `86.95% <0%> (+0.18%)` | :arrow_up: | | [server/govern/service.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/449/diff?src=pr&el=tree#diff-c2VydmVyL2dvdmVybi9zZXJ2aWNlLmdv) | `73.66% <0%> (+0.33%)` | :arrow_up: | | [server/service/notification/websocket.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/449/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2Uvbm90aWZpY2F0aW9uL3dlYnNvY2tldC5nbw==) | `84.51% <0%> (+0.64%)` | :arrow_up: | | [pkg/tlsutil/tlsutil.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/449/diff?src=pr&el=tree#diff-cGtnL3Rsc3V0aWwvdGxzdXRpbC5nbw==) | `74.52% <0%> (+0.94%)` | :arrow_up: | | [pkg/util/tree.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/449/diff?src=pr&el=tree#diff-cGtnL3V0aWwvdHJlZS5nbw==) | `84.37% <0%> (+3.12%)` | :arrow_up: | | [...ver/plugin/infra/tracing/buildin/file\_collector.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/449/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9pbmZyYS90cmFjaW5nL2J1aWxkaW4vZmlsZV9jb2xsZWN0b3IuZ28=) | `63.1% <0%> (+10.67%)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/449?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/449?src=pr&el=footer). Last update [95013d4...1ac5a79](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/449?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] > Customizable tracing sample rate > -------------------------------- > > Key: SCB-937 > URL: https://issues.apache.org/jira/browse/SCB-937 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Service-Center > Reporter: little-cui > Assignee: little-cui > Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
