[
https://issues.apache.org/jira/browse/SCB-926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16628694#comment-16628694
]
ASF GitHub Bot commented on SCB-926:
------------------------------------
liubao68 commented on a change in pull request #915: [SCB-926] support invoking
3rd party service
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/915#discussion_r220543507
##########
File path:
core/src/main/java/org/apache/servicecomb/core/definition/MicroserviceVersionMeta.java
##########
@@ -20,10 +20,15 @@
import org.apache.servicecomb.core.CseContext;
import
org.apache.servicecomb.core.definition.classloader.MicroserviceClassLoaderFactory;
import org.apache.servicecomb.serviceregistry.api.Const;
+import org.apache.servicecomb.serviceregistry.api.registry.Microservice;
import org.apache.servicecomb.serviceregistry.consumer.MicroserviceVersion;
public class MicroserviceVersionMeta extends MicroserviceVersion {
- private MicroserviceMeta microserviceMeta;
+ MicroserviceMeta microserviceMeta;
+
+ MicroserviceVersionMeta(Microservice microservice) {
Review comment:
microserviceMeta is not initialized, and getMicroserviceMeta may return null
and cause NPE.
From the following code, I think it's better to define the method protected
that should be override by sub class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Invoke 3rd party service
> ------------------------
>
> Key: SCB-926
> URL: https://issues.apache.org/jira/browse/SCB-926
> Project: Apache ServiceComb
> Issue Type: New Feature
> Affects Versions: java-chassis-1.1.0
> Reporter: YaoHaishi
> Assignee: YaoHaishi
> Priority: Major
>
> Provide a interface to let users specify 3rd party services' endpoints and
> let users can invoke 3rd party service like invoking the ServiceComb
> microservice.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
