[ https://issues.apache.org/jira/browse/SCB-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16632759#comment-16632759 ]
ASF GitHub Bot commented on SCB-941: ------------------------------------ codecov-io commented on issue #452: SCB-941 Add an example of multiple datacenters discovery URL: https://github.com/apache/incubator-servicecomb-service-center/pull/452#issuecomment-425611662 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/452?src=pr&el=h1) Report > Merging [#452](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/452?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/14b3acb261ca29a093ee12572f1c85a2d6be96e5?src=pr&el=desc) will **increase** coverage by `0.23%`. > The diff coverage is `100%`. [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/452/graphs/tree.svg?width=650&token=GAaF7zrg8R&height=150&src=pr)](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/452?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #452 +/- ## ========================================== + Coverage 60% 60.23% +0.23% ========================================== Files 156 156 Lines 13388 13392 +4 ========================================== + Hits 8033 8067 +34 + Misses 4776 4748 -28 + Partials 579 577 -2 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/452?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [server/plugin/pkg/discovery/cache\_kv.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/452/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L2NhY2hlX2t2Lmdv) | `95.78% <100%> (+0.18%)` | :arrow_up: | | [server/plugin/pkg/discovery/types.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/452/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3R5cGVzLmdv) | `100% <100%> (+22.22%)` | :arrow_up: | | [server/service/notification/websocket.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/452/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2Uvbm90aWZpY2F0aW9uL3dlYnNvY2tldC5nbw==) | `83.87% <0%> (-0.65%)` | :arrow_down: | | [server/service/instance.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/452/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvaW5zdGFuY2UuZ28=) | `68.53% <0%> (+0.19%)` | :arrow_up: | | [server/govern/service.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/452/diff?src=pr&el=tree#diff-c2VydmVyL2dvdmVybi9zZXJ2aWNlLmdv) | `73.66% <0%> (+0.33%)` | :arrow_up: | | [pkg/tlsutil/tlsutil.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/452/diff?src=pr&el=tree#diff-cGtnL3Rsc3V0aWwvdGxzdXRpbC5nbw==) | `74.52% <0%> (+0.94%)` | :arrow_up: | | [server/plugin/pkg/discovery/cacher.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/452/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L2NhY2hlci5nbw==) | `100% <0%> (+100%)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/452?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/452?src=pr&el=footer). Last update [14b3acb...1c13756](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/452?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Support multiple datacenter deployment > -------------------------------------- > > Key: SCB-941 > URL: https://issues.apache.org/jira/browse/SCB-941 > Project: Apache ServiceComb > Issue Type: New Feature > Components: Service-Center > Reporter: little-cui > Assignee: little-cui > Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)