[
https://issues.apache.org/jira/browse/SCB-837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16654406#comment-16654406
]
ASF GitHub Bot commented on SCB-837:
------------------------------------
heyile commented on a change in pull request #947: [SCB-837] make http2
production ready
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/947#discussion_r226131786
##########
File path:
foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundation/vertx/metrics/DefaultHttpClientMetrics.java
##########
@@ -133,7 +139,24 @@ public void disconnected(Object webSocketMetric) {
@Override
public DefaultHttpSocketMetric connected(SocketAddress remoteAddress, String
remoteName) {
- return new DefaultHttpSocketMetric(null);
+ // when host of createEndpoint is not ip but a hostName
+ // get from remoteAddress will return null
+ // in this time need to try again with remoteName
+ // connected is a low frequency method, this try logic will not cause
performance problem
+
+ DefaultClientEndpointMetric clientEndpointMetric =
this.clientEndpointMetricManager
+ .getClientEndpointMetric(remoteAddress);
+ if (clientEndpointMetric == null) {
+ LOGGER.warn("can not find endpointMetric directly by remoteAddress {},
try again with remoteName {}",
Review comment:
ok, get
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> make http2 production ready
> ---------------------------
>
> Key: SCB-837
> URL: https://issues.apache.org/jira/browse/SCB-837
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Java-Chassis
> Reporter: wujimin
> Assignee: 何一乐
> Priority: Major
> Fix For: java-chassis-1.1.0
>
>
> currenty, http2 client use all http1.1 settings, that cause http2 client
> performance is so bad.
>
> we need to conside http2 client settings at least:
> 1.concurrent stream in one connection, default value is 3, we must make it
> bigger
> 2.maxPoolSize, http1.1 need a big pool, but http2 need a big concurrent
> stream count
>
> we must perform a performance test, that make sure got a good result, and
> then set the setting to be our default setting.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
