[
https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16693929#comment-16693929
]
ASF GitHub Bot commented on SCB-993:
------------------------------------
little-cui commented on a change in pull request #493: WIP: SCB-993 search sc
cluster when key mismatch with aggregator cache
URL:
https://github.com/apache/servicecomb-service-center/pull/493#discussion_r235215710
##########
File path: server/service/notification/websocket.go
##########
@@ -181,7 +181,9 @@ func (wh *WebSocket) HandleWatchWebSocketJob(o
interface{}) {
message = util.StringToBytesWithNoCopy(fmt.Sprintf("watcher
catch an err: %s", err.Error()))
case time.Time:
domainProject := util.ParseDomainProject(wh.ctx)
- if !serviceUtil.ServiceExist(wh.ctx, domainProject,
wh.watcher.Group()) {
+ if !serviceUtil.ServiceExist(
+ context.WithValue(wh.ctx, serviceUtil.CTX_REGISTRYONLY,
"1"),
+ domainProject, wh.watcher.Group()) {
Review comment:
error logic, we don’t only require consumer registered locally
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Bug fixes
> ---------
>
> Key: SCB-993
> URL: https://issues.apache.org/jira/browse/SCB-993
> Project: Apache ServiceComb
> Issue Type: Bug
> Components: Service-Center
> Reporter: little-cui
> Assignee: little-cui
> Priority: Major
> Fix For: service-center-1.1.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
