[
https://issues.apache.org/jira/browse/SCB-1043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16697592#comment-16697592
]
ASF GitHub Bot commented on SCB-1043:
-------------------------------------
wujimin commented on a change in pull request #1006: [SCB-1043] fix bug: if
safeSetInstances throw an exception, the excep…
URL:
https://github.com/apache/servicecomb-java-chassis/pull/1006#discussion_r236029857
##########
File path:
service-registry/src/main/java/org/apache/servicecomb/serviceregistry/consumer/MicroserviceVersions.java
##########
@@ -160,10 +160,10 @@ protected void
safeSetInstances(List<MicroserviceInstance> pulledInstances, Stri
setInstances(pulledInstances, rev);
validated = true;
} catch (Throwable e) {
- LOGGER.error("Failed to setInstances, appId={}, microserviceName={}.",
- getAppId(),
- getMicroserviceName(),
- e);
+ LOGGER.error(String.format("Failed to setInstances, AppId=%s,
MicroserviceName=%s.",
Review comment:
when will lost exception?
by my test, never happened.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> MicroserviceVersions.safeSetInstances lost exception message
> ------------------------------------------------------------
>
> Key: SCB-1043
> URL: https://issues.apache.org/jira/browse/SCB-1043
> Project: Apache ServiceComb
> Issue Type: Bug
> Components: Java-Chassis
> Reporter: jeho0815
> Assignee: jeho0815
> Priority: Major
> Fix For: java-chassis-1.1.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
