[
https://issues.apache.org/jira/browse/SCB-925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16700307#comment-16700307
]
ASF GitHub Bot commented on SCB-925:
------------------------------------
liubao68 commented on a change in pull request #1004: [SCB-925] Springmvc, when
have defaultValue, required should be false, when param not exist, should check
isRequired
URL:
https://github.com/apache/servicecomb-java-chassis/pull/1004#discussion_r236632935
##########
File path:
common/common-rest/src/test/java/org/apache/servicecomb/common/rest/codec/param/TestCookieProcessor.java
##########
@@ -67,8 +71,12 @@ public void testGetValueNoCookies() throws Exception {
};
CookieProcessor processor = createProcessor("c1", String.class);
- Object value = processor.getValue(request);
- Assert.assertNull(value);
+ try {
+ processor.getValue(request);
Review comment:
This is a behavior change. And it's better to add a new test case which have
the same meaning as the old test case.
CookieProcessor processor = createProcessor("c1", String.class, null, false);
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Springmvc, when have defaultValue, required should be false
> -----------------------------------------------------------
>
> Key: SCB-925
> URL: https://issues.apache.org/jira/browse/SCB-925
> Project: Apache ServiceComb
> Issue Type: Bug
> Components: Java-Chassis
> Reporter: WeiChao
> Assignee: WeiChao
> Priority: Major
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
