[
https://issues.apache.org/jira/browse/SCB-1065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16708399#comment-16708399
]
ASF GitHub Bot commented on SCB-1065:
-------------------------------------
wujimin commented on a change in pull request #1022: [SCB-1065] when request
not contain traceId,should use provider's invocation's traceId
URL:
https://github.com/apache/servicecomb-java-chassis/pull/1022#discussion_r238569551
##########
File path:
common/common-rest/src/main/java/org/apache/servicecomb/common/rest/AbstractRestInvocation.java
##########
@@ -103,7 +103,7 @@ protected void setContext() throws Exception {
@SuppressWarnings("unchecked")
Map<String, String> cseContext =
JsonUtils.readValue(strCseContext.getBytes(StandardCharsets.UTF_8),
Map.class);
- invocation.setContext(cseContext);
+ invocation.addContext(cseContext);
Review comment:
highway have the same problem
we can add a new method in invocation: mergeContext
1.if new context have more items, then addAll to new context, and replace
old context
2.if new context have less items, then allAll to old context directly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> when request not contain traceId,should use provider's invocation's traceId
> ---------------------------------------------------------------------------
>
> Key: SCB-1065
> URL: https://issues.apache.org/jira/browse/SCB-1065
> Project: Apache ServiceComb
> Issue Type: Bug
> Components: Java-Chassis
> Reporter: WeiChao
> Assignee: WeiChao
> Priority: Major
> Fix For: java-chassis-1.2.0
>
>
> when request not contain traceId,should use provider's invocation's traceId
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
