[jira] Commented: (SHALE-439) Add check to ensure that the value of renderId is a numeric value when declaring Clay components

[Ryan Wynn (JIRA)]

    [ 
https://issues.apache.org/struts/browse/SHALE-439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_42681
 ] 

Ryan Wynn commented on SHALE-439:
---------------------------------

Should this be closed now?  It looks like it may have bean fixed in 
ElementBuilder.java

        String renderId = (String) node.getAttributes().get("renderId");
        if (renderId != null) {
           Integer id = null;
           try {
            id = Integer.valueOf(renderId);
           } catch (NumberFormatException e) {
               log.error(e);
               throw new RuntimeException(
                       messages.getMessage("parser.unresolved",
                       new Object[] {node.getToken(), 
node.getToken().getRawText()}));
           }
           if (id != null) {
              target.setRenderId(id.intValue());
           }
        }


> Add check to ensure that the value of renderId is a numeric value when 
> declaring Clay components
> ------------------------------------------------------------------------------------------------
>
>                 Key: SHALE-439
>                 URL: https://issues.apache.org/struts/browse/SHALE-439
>             Project: Shale
>          Issue Type: Improvement
>          Components: Clay
>            Reporter: Hermod Opstvedt
>            Priority: Minor
>
> Currently there is no check that the renderId's are numeric. This causes some 
> odd behaviour when faces tries to render components.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.