[
https://issues.apache.org/jira/browse/SHINDIG-1452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12923822#action_12923822
]
Paul Lindner commented on SHINDIG-1452:
---------------------------------------
I'll need to adjust this for trunk since there have been some changes since
2.0.x
Thanks for the patch, it looks good.
> Allow FeedProcessor to be swapped out via Guice injection
> ---------------------------------------------------------
>
> Key: SHINDIG-1452
> URL: https://issues.apache.org/jira/browse/SHINDIG-1452
> Project: Shindig
> Issue Type: Improvement
> Components: Java
> Affects Versions: 2.0.0
> Reporter: Bill Wolcken
> Priority: Minor
> Attachments:
> 0001-Convert-FeedProcessor-to-an-interface-and-allow-for-.patch
>
>
> Many classes within Shindig can be easily swapped out and replaced by
> container implementations via Guice injection. FeedProcessor is not one of
> them, since HttpRequestHandler and MakeRequestHandler directly instantiate
> instances of FeedProcessor. To allow FeedProcessor to be swapped out,
> FeedProcessor should be replaced with an interface/implementation pair, and
> HttpRequestHandler and MakeRequestHandler should accept a FeedProcessor
> Provider as a constructor argument.
> I have made the above described changes against the 2.0.x baseline in the
> Shindig project fork used by Eureka Streams. I will attempt to upload and
> attach a git patch file for the changes. (The fork also had prior changes to
> FeedProcessor to support feed images, so that additional feature comes along
> too.)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
