[
https://issues.apache.org/jira/browse/SHINDIG-1624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13125895#comment-13125895
]
[email protected] commented on SHINDIG-1624:
--------------------------------------------------------
bq. On 2011-09-27 17:46:35, Ryan Baxter wrote:
bq. >
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2RequestException.java,
line 24
bq. > <https://reviews.apache.org/r/1947/diff/3/?file=45539#file45539line24>
bq. >
bq. > Make sure the javadoc is complete
agreed
bq. On 2011-09-27 17:46:35, Ryan Baxter wrote:
bq. >
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2ResponseParams.java,
line 34
bq. > <https://reviews.apache.org/r/1947/diff/3/?file=45540#file45540line34>
bq. >
bq. > Make sure the javadoc is complete
agreed
bq. On 2011-09-27 17:46:35, Ryan Baxter wrote:
bq. >
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2ResponseParams.java,
line 91
bq. > <https://reviews.apache.org/r/1947/diff/3/?file=45540#file45540line91>
bq. >
bq. > Should use a StringBuffer
agreed,replaced with StringBuilder.
bq. On 2011-09-27 17:46:35, Ryan Baxter wrote:
bq. >
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Store.java,
line 133
bq. > <https://reviews.apache.org/r/1947/diff/3/?file=45541#file45541line133>
bq. >
bq. > what does this return?
fixed
bq. On 2011-09-27 17:46:35, Ryan Baxter wrote:
bq. >
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Token.java,
line 32
bq. > <https://reviews.apache.org/r/1947/diff/3/?file=45542#file45542line32>
bq. >
bq. > Make sure the javadoc is complete
agreed
bq. On 2011-09-27 17:46:35, Ryan Baxter wrote:
bq. >
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Utils.java,
line 66
bq. > <https://reviews.apache.org/r/1947/diff/3/?file=45543#file45543line66>
bq. >
bq. > Use the Maps API
done
bq. On 2011-09-27 17:46:35, Ryan Baxter wrote:
bq. >
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Utils.java,
line 69
bq. > <https://reviews.apache.org/r/1947/diff/3/?file=45543#file45543line69>
bq. >
bq. > Should we check the list's size before accessing any of the elements
in it?
done
bq. On 2011-09-27 17:46:35, Ryan Baxter wrote:
bq. >
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Utils.java,
line 76
bq. > <https://reviews.apache.org/r/1947/diff/3/?file=45543#file45543line76>
bq. >
bq. > Should we check the list's size before accessing any of the elements
in it?
done
bq. On 2011-09-27 17:46:35, Ryan Baxter wrote:
bq. >
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Utils.java,
line 156
bq. > <https://reviews.apache.org/r/1947/diff/3/?file=45543#file45543line156>
bq. >
bq. > Log this exception
done
bq. On 2011-09-27 17:46:35, Ryan Baxter wrote:
bq. >
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/AuthorizationEndpointResponseHandler.java,
line 39
bq. > <https://reviews.apache.org/r/1947/diff/3/?file=45544#file45544line39>
bq. >
bq. > Make sure the javadoc is complete
agreed
bq. On 2011-09-27 17:46:35, Ryan Baxter wrote:
bq. >
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/ClientAuthenticationHandler.java,
line 36
bq. > <https://reviews.apache.org/r/1947/diff/3/?file=45545#file45545line36>
bq. >
bq. > Make sure the javadoc is complete
agreed
bq. On 2011-09-27 17:46:35, Ryan Baxter wrote:
bq. >
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/GrantRequestHandler.java,
line 35
bq. > <https://reviews.apache.org/r/1947/diff/3/?file=45546#file45546line35>
bq. >
bq. > Make sure the javadoc is complete
agreed
bq. On 2011-09-27 17:46:35, Ryan Baxter wrote:
bq. >
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/OAuth2HandlerError.java,
line 28
bq. > <https://reviews.apache.org/r/1947/diff/3/?file=45547#file45547line28>
bq. >
bq. > Make sure the javadoc is complete
agreed
bq. On 2011-09-27 17:46:35, Ryan Baxter wrote:
bq. >
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/ResourceRequestHandler.java,
line 35
bq. > <https://reviews.apache.org/r/1947/diff/3/?file=45548#file45548line35>
bq. >
bq. > Make sure the javadoc is complete
agreed
bq. On 2011-09-27 17:46:35, Ryan Baxter wrote:
bq. >
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/TokenEndpointResponseHandler.java,
line 32
bq. > <https://reviews.apache.org/r/1947/diff/3/?file=45549#file45549line32>
bq. >
bq. > Make sure the javadoc is complete
agreed
bq. On 2011-09-27 17:46:35, Ryan Baxter wrote:
bq. >
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/sample/BearerTokenHandler.java,
line 73
bq. > <https://reviews.apache.org/r/1947/diff/3/?file=45551#file45551line73>
bq. >
bq. > Use the Maps API
done
bq. On 2011-09-27 17:46:35, Ryan Baxter wrote:
bq. >
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/sample/ClientCredentialsGrantTypeHandler.java,
line 56
bq. > <https://reviews.apache.org/r/1947/diff/3/?file=45552#file45552line56>
bq. >
bq. > Use the Maps API
done
bq. On 2011-09-27 17:46:35, Ryan Baxter wrote:
bq. >
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/sample/CodeAuthorizationResponseHandler.java,
line 69
bq. > <https://reviews.apache.org/r/1947/diff/3/?file=45553#file45553line69>
bq. >
bq. > Use the Maps API
done
bq. On 2011-09-27 17:46:35, Ryan Baxter wrote:
bq. >
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/sample/CodeGrantTypeHandler.java,
line 48
bq. > <https://reviews.apache.org/r/1947/diff/3/?file=45554#file45554line48>
bq. >
bq. > Use the Maps API
done
bq. On 2011-09-27 17:46:35, Ryan Baxter wrote:
bq. >
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/sample/MACTokenHandler.java,
line 145
bq. > <https://reviews.apache.org/r/1947/diff/3/?file=45555#file45555line145>
bq. >
bq. > NIT: Might help to have a helper class for this to make this code
cleaner
split the function into a seperate function to make it more readable... the
header string is unique to Mac token type.
bq. On 2011-09-27 17:46:35, Ryan Baxter wrote:
bq. >
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Utils.java,
line 38
bq. > <https://reviews.apache.org/r/1947/diff/3/?file=45543#file45543line38>
bq. >
bq. > Does this belong in the commons project?
bq. > Make sure the javadoc is complete
OAuth2 consumer specific utility. agreed.
bq. On 2011-09-27 17:46:35, Ryan Baxter wrote:
bq. >
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/sample/BasicOAuth2Message.java,
line 186
bq. > <https://reviews.apache.org/r/1947/diff/3/?file=45573#file45573line186>
bq. >
bq. > Not sure we want to call out facebook
removed
bq. On 2011-09-27 17:46:35, Ryan Baxter wrote:
bq. >
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/OAuth2CallbackServlet.java,
line 132
bq. > <https://reviews.apache.org/r/1947/diff/3/?file=45579#file45579line132>
bq. >
bq. > Could you break here after you set foundHandler to true
fixed
bq. On 2011-09-27 17:46:35, Ryan Baxter wrote:
bq. >
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/sample/JSONOAuth2Persister.java,
line 95
bq. > <https://reviews.apache.org/r/1947/diff/3/?file=45568#file45568line95>
bq. >
bq. > Want to log these exceptions
done
bq. On 2011-09-27 17:46:35, Ryan Baxter wrote:
bq. >
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/sample/JSONOAuth2Persister.java,
line 200
bq. > <https://reviews.apache.org/r/1947/diff/3/?file=45568#file45568line200>
bq. >
bq. > Remove this
done
bq. On 2011-09-27 17:46:35, Ryan Baxter wrote:
bq. >
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/sample/JSONOAuth2Persister.java,
line 248
bq. > <https://reviews.apache.org/r/1947/diff/3/?file=45568#file45568line248>
bq. >
bq. > Remove this
done
bq. On 2011-09-27 17:46:35, Ryan Baxter wrote:
bq. >
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/sample/JSONOAuth2Persister.java,
line 304
bq. > <https://reviews.apache.org/r/1947/diff/3/?file=45568#file45568line304>
bq. >
bq. > Remove this
done
bq. On 2011-09-27 17:46:35, Ryan Baxter wrote:
bq. >
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/sample/OAuth2GadgetBinding.java,
line 23
bq. > <https://reviews.apache.org/r/1947/diff/3/?file=45570#file45570line23>
bq. >
bq. > Add Javadoc
agreed
bq. On 2011-09-27 17:46:35, Ryan Baxter wrote:
bq. >
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/sample/OAuth2Provider.java,
line 25
bq. > <https://reviews.apache.org/r/1947/diff/3/?file=45572#file45572line25>
bq. >
bq. > Add Javadoc
agreed
bq. On 2011-09-27 17:46:35, Ryan Baxter wrote:
bq. >
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/OAuth2CallbackServlet.java,
line 182
bq. > <https://reviews.apache.org/r/1947/diff/3/?file=45579#file45579line182>
bq. >
bq. > Would it be better to just have a constructor where there are
injected instead of just having the default constructor?
servlet spec requires configuration being done in init() thus can't handle
constructor injection for servlet. please see comments in
InjectedServlet.
bq. On 2011-09-27 17:46:35, Ryan Baxter wrote:
bq. >
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/spec/OAuth2Service.java,
line 40
bq. > <https://reviews.apache.org/r/1947/diff/3/?file=45581#file45581line40>
bq. >
bq. > Make sure Javadoc is complete
bq. > Is there any code we can share between the OAuth2 service and the
OAuth1 service?
agreed about javadoc.
created BaseOAuthService.
bq. On 2011-09-27 17:46:35, Ryan Baxter wrote:
bq. >
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/spec/OAuth2Spec.java,
line 36
bq. > <https://reviews.apache.org/r/1947/diff/3/?file=45582#file45582line36>
bq. >
bq. > Make sure the Javadoc is complete
bq. > Can we share any code between the OAuth2 spec and the OAuth1 spec?
agreed about javadoc. need to be unique to different service: OAuthService or
OAuth2Service.
bq. On 2011-09-27 17:46:35, Ryan Baxter wrote:
bq. >
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2Cache.java,
line 31
bq. > <https://reviews.apache.org/r/1947/diff/3/?file=45559#file45559line31>
bq. >
bq. > Make sure javadoc is complete
agreed
bq. On 2011-09-27 17:46:35, Ryan Baxter wrote:
bq. >
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2Client.java,
line 33
bq. > <https://reviews.apache.org/r/1947/diff/3/?file=45561#file45561line33>
bq. >
bq. > Make sure the javadoc is complete
agreed
bq. On 2011-09-27 17:46:35, Ryan Baxter wrote:
bq. >
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2Encrypter.java,
line 27
bq. > <https://reviews.apache.org/r/1947/diff/3/?file=45562#file45562line27>
bq. >
bq. > Make sure the javadoc is compelte
agreed
bq. On 2011-09-27 17:46:35, Ryan Baxter wrote:
bq. >
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2Persister.java,
line 41
bq. > <https://reviews.apache.org/r/1947/diff/3/?file=45565#file45565line41>
bq. >
bq. > Make sure the javadoc is complete
agreed
bq. On 2011-09-27 17:46:35, Ryan Baxter wrote:
bq. >
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/sample/TokenAuthorizationResponseHandler.java,
line 76
bq. > <https://reviews.apache.org/r/1947/diff/3/?file=45558#file45558line76>
bq. >
bq. > Is the spec vague about the content type? Why does Facebook and
Google have two different content types?
spec is not vague, however Facebook seems behind the spec.
bq. On 2011-09-27 17:46:35, Ryan Baxter wrote:
bq. >
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/sample/MACTokenHandler.java,
line 197
bq. > <https://reviews.apache.org/r/1947/diff/3/?file=45555#file45555line197>
bq. >
bq. > NIT: There are alot of params here, consider making a POJO object
and passing that in.
agreed
- li
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1947/#review2092
-----------------------------------------------------------
On 2011-10-12 14:52:23, li xu wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1947/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-10-12 14:52:23)
bq.
bq.
bq. Review request for shindig.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. OAuth 2.0 client implementation in Apache Shindig from Adam Clarke, Eric
Woods, Jeff Hoy, Li Xu and Matthew Marum.
bq.
bq.
bq. Documentation wiki:
http://docs.opensocial.org/display/OSD/OAuth+2.0+Consumer+Implementation+in+Apache+Shindig
bq.
bq.
bq. JIRA issue: https://issues.apache.org/jira/browse/SHINDIG-1624
bq.
bq. OAuth2 test gadgets are added to common container test page and can be
tested by using
bq. http://localhost:8080/samplecontainer/examples/commoncontainer/index.html
bq.
bq. You will need OAuth2 service provider implementation to test following two
gadgets:
bq. OAuth2 demo with Shindig Provider (Authorization Code)
bq. OAuth2 demo with Shindig Provider (Client credential )
bq.
bq. You will need to have your own google/facebook client to test following
two gadgets
bq. OAuth2 demo with Google Provider
bq. OAuth2 demo with Facebook Provider
bq. Once it's registered with Google/Facebook, you can register the
client-id/pwd under
bq. /config/oauth2.json
bq.
bq.
bq. This addresses bug shindig-1624.
bq. https://issues.apache.org/jira/browse/shindig-1624
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. /trunk/config/oauth2.json PRE-CREATION
bq.
/trunk/content/samplecontainer/examples/commoncontainer/gadgetCollections.json
1182008
bq. /trunk/content/samplecontainer/examples/oauth2/oauth2_facebook.xml
PRE-CREATION
bq. /trunk/content/samplecontainer/examples/oauth2/oauth2_google.xml
PRE-CREATION
bq. /trunk/content/samplecontainer/examples/oauth2/oauth2_windowslive.xml
PRE-CREATION
bq. /trunk/content/samplecontainer/examples/oauth2/shindig_authorization.xml
PRE-CREATION
bq.
/trunk/content/samplecontainer/examples/oauth2/shindig_client_credentials.xml
PRE-CREATION
bq. /trunk/features/src/main/javascript/features/core.io/io.js 1182008
bq.
/trunk/features/src/main/javascript/features/shindig.xhrwrapper/xhrwrapper.js
1182008
bq. /trunk/java/common/conf/shindig.properties 1182008
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/AuthType.java
1182008
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/config/XhrwrapperConfigContributor.java
1182008
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/AbstractHttpCache.java
1182008
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/DefaultInvalidationService.java
1182008
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/DefaultRequestPipeline.java
1182008
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpRequest.java
1182008
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/GadgetOAuthTokenStore.java
1182008
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Accessor.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Message.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Request.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Store.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/GadgetOAuth2TokenStore.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Accessor.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Arguments.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Error.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2FetcherConfig.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2GadgetContext.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Message.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2MessageModule.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Module.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Request.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2RequestException.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2ResponseParams.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Store.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Token.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Utils.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/AuthorizationEndpointResponseHandler.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/BasicAuthenticationHandler.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/BearerTokenHandler.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/ClientAuthenticationHandler.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/ClientCredentialsGrantTypeHandler.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/CodeAuthorizationResponseHandler.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/CodeGrantTypeHandler.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/GrantRequestHandler.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/MacTokenHandler.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/OAuth2HandlerError.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/OAuth2HandlerModule.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/ResourceRequestHandler.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/StandardAuthenticationHandler.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/TokenAuthorizationResponseHandler.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/TokenEndpointResponseHandler.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/logger/FilteredLogger.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2Cache.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2CacheException.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2Client.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2Encrypter.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2EncryptionException.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2PersistenceException.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2Persister.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2TokenPersistence.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/sample/InMemoryCache.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/sample/JSONOAuth2Persister.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/sample/NoOpEncrypter.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/sample/OAuth2GadgetBinding.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/sample/OAuth2PersistenceModule.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/sample/OAuth2Provider.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/preload/HttpPreloader.java
1182008
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/render/ProxyRenderer.java
1182008
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/HttpRequestHandler.java
1182008
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java
1182008
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/OAuth2CallbackServlet.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/spec/BaseOAuthService.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/spec/ModulePrefs.java
1182008
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/spec/OAuth2Service.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/spec/OAuth2Spec.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/spec/OAuthService.java
1182008
bq.
/trunk/java/gadgets/src/main/resources/org/apache/shindig/gadgets/oauth2/resource.properties
PRE-CREATION
bq.
/trunk/java/gadgets/src/main/resources/org/apache/shindig/gadgets/oauth2/resource_en_US.properties
PRE-CREATION
bq.
/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/AuthTypeTest.java
1182008
bq.
/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/http/DefaultInvalidationServiceTest.java
1182008
bq.
/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/http/DefaultRequestPipelineTest.java
1182008
bq.
/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/GadgetOAuth2TokenStoreTest.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/MockUtils.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/OAuth2ArgumentsTest.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/OAuth2ErrorTest.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/OAuth2FetcherConfigTest.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/OAuth2GadgetContextTest.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/OAuth2MessageModuleTest.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/OAuth2ModuleTest.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/OAuth2RequestExceptionTest.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/OAuth2ResponseParamsTest.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/handler/BasicAuthenticationHandlerTest.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/handler/BearerTokenHandlerTest.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/handler/ClientCredentialsGrantTypeHandlerTest.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/handler/CodeAuthorizationResponseHandlerTest.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/handler/CodeGrantTypeHandlerTest.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/handler/MacTokenHandlerTest.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/handler/OAuth2HandlerErrorTest.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/handler/OAuth2HandlerModuleTest.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/handler/StandardAuthenticationHandlerTest.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/handler/TokenAuthorizationResponseHandlerTest.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/logger/FilteredLoggerTest.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2CacheExceptionTest.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2ClientTest.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2EncryptionExceptionTest.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2PersistenceExceptionTest.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2TokenPersistenceTest.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/persistence/sample/InMemoryCacheTest.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/persistence/sample/JSONOAuth2PersisterTest.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/persistence/sample/NoOpEncrypterTest.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/persistence/sample/OAuth2GadgetBindingTest.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/persistence/sample/OAuth2PersistenceModuleTest.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/persistence/sample/OAuth2ProviderTest.java
PRE-CREATION
bq.
/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/RewriteModuleTest.java
1182008
bq.
/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/StyleTagProxyEmbeddedUrlsVisitorTest.java
1182008
bq.
/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/templates/tags/TemplateBasedTagHandlerTest.java
1182008
bq.
/trunk/java/gadgets/src/test/resources/org/apache/shindig/gadgets/oauth2/oauth2_test.json
PRE-CREATION
bq. /trunk/java/server/pom.xml 1182008
bq. /trunk/java/server/src/main/webapp/WEB-INF/web.xml 1182008
bq.
/trunk/java/server/src/test/java/org/apache/shindig/server/endtoend/EndToEndServer.java
1182008
bq.
bq. Diff: https://reviews.apache.org/r/1947/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Yes, passed all JUnit tests with mantis build. tested with new OAuth2 demo
pages.
bq.
bq.
bq. Thanks,
bq.
bq. li
bq.
bq.
> OAuth 2.0 Consumer Java implementation for Shindig 3.0
> ------------------------------------------------------
>
> Key: SHINDIG-1624
> URL: https://issues.apache.org/jira/browse/SHINDIG-1624
> Project: Shindig
> Issue Type: Sub-task
> Components: Java
> Affects Versions: 3.0.0
> Reporter: Adam Clarke
> Fix For: 3.0.0
>
> Attachments: 20110921
>
> Original Estimate: 1,344h
> Remaining Estimate: 1,344h
>
> Developing an extensible OAuth 2.0 component for Shindig 3.0.0 tested against
> Google, Facebook and the Shindig Provider developed by Matt and Eric.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
