[
https://issues.apache.org/jira/browse/SHINDIG-1709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13215009#comment-13215009
]
[email protected] commented on SHINDIG-1709:
--------------------------------------------------------
bq. On 2012-02-23 18:10:07, Henry Saputra wrote:
bq. >
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/admin/BasicGadgetAdminStore.java,
line 51
bq. > <https://reviews.apache.org/r/3938/diff/3/?file=76150#file76150line51>
bq. >
bq. > Not sure if we need this annotation. Probably just add @since
instead. And remember we are releasing 2.5.0 instead of 3.0.0 for next release.
Good point, I will fix that.
- Ryan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3938/#review5311
-----------------------------------------------------------
On 2012-02-20 21:48:36, Ryan Baxter wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3938/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-02-20 21:48:36)
bq.
bq.
bq. Review request for shindig.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. If you enable RPC arbitration in a container and you want to allow a set
of RPC service ids regardless of whether the gadgets has features that uses
them, it is very difficult to do so. The only way to do this today is to
provide your own arbitrator function to the common container. Essentially this
function will do the same thing as the default implementation in the common
container except have a list of allowed RPC service ids. It be easier if
containers could specify a list of additional RPC services to allow on a per
gadget basis. It would also be nice if this was integrated into the gadget
admin feature in Shindig already.
bq.
bq.
bq. This addresses bug SHINDIG-1709.
bq. https://issues.apache.org/jira/browse/SHINDIG-1709
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/shindig/trunk/config/gadget-admin.json
1245178
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js
1245178
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/admin/BasicGadgetAdminStore.java
1245178
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/admin/GadgetAdminData.java
1245178
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/admin/GadgetAdminStore.java
1245178
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/admin/RpcAdminData.java
PRE-CREATION
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java
1245178
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/admin/BasicGadgetAdminStoreTest.java
1245178
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/admin/ContainerAdminDataTest.java
1245178
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/admin/GadgetAdminDataTest.java
1245178
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/admin/RpcAdminDataTest.java
PRE-CREATION
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/admin/ServerAdminDataTest.java
1245178
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerServiceTest.java
1245178
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerTest.java
1245178
bq.
bq. Diff: https://reviews.apache.org/r/3938/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Updated and added unit tests. Also tested in common container.
bq.
bq.
bq. Thanks,
bq.
bq. Ryan
bq.
bq.
> The RPC abritration code in the common container should allow you to pass in
> a list of allowed RPC services for that container.
> -------------------------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1709
> URL: https://issues.apache.org/jira/browse/SHINDIG-1709
> Project: Shindig
> Issue Type: Improvement
> Reporter: Ryan Baxter
> Assignee: Ryan Baxter
> Attachments: issue-1709.patch
>
>
> If you enable RPC arbitration in a container and you want to allow a set of
> RPC service ids regardless of whether the gadgets has features that uses
> them, it is very difficult to do so. The only way to do this today is to
> provide your own arbitrator function to the common container. Essentially
> this function will do the same thing as the default implementation in the
> common container except have a list of allowed RPC service ids. It be easier
> if containers could specify a list of additional RPC services to allow on a
> per gadget basis. It would also be nice if this was integrated into the
> gadget admin feature in Shindig already.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
