[
https://issues.apache.org/jira/browse/SHINDIG-1767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13271464#comment-13271464
]
jirapos...@reviews.apache.org commented on SHINDIG-1767:
--------------------------------------------------------
bq. On 2012-05-09 12:04:59, Stanton Sievers wrote:
bq. > To be honest, your code changes make my head hurt. However, I applied
the patch and was playing around with it in the sample common container page
with the gadget you provided. I noticed that if I click the "fit-width"
button, the "fit-height" button actually wraps onto a new line in FF12.
fit-height seems to work just fine.
bq. >
bq. > Also, if I change the "dir" on the body to "rtl", fit-width seems to
have no effect and "skinny" just hoses the gadget - I lose my vertical scroll
bar and can't find the buttons.
bq.
bq. Dan Dumont wrote:
bq. Argh...
bq.
bq. Width is going to be *very* problematic to auto-adjust to. The code
currently does a breadth-first search to find all children with dimensions we
care about... This makes keeping track of dir=inherit styles pretty hard...
bq.
bq. I'll take a look at it and see what we can do... I'm starting to
wonder if auto-adjust is even worth it. Wouldn't a gadget know better than us
what kind of real estate it would need? It might just be better to deprecate
the auto-adjust in the spec.
I guess it might not be that hard. It looks like getting a computed style on
something marked "inherit" will give me the correct ltr/rtl attribute.
- Dan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5067/#review7731
-----------------------------------------------------------
On 2012-05-09 14:46:39, Dan Dumont wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/5067/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-05-09 14:46:39)
bq.
bq.
bq. Review request for shindig.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. With the latest changes from
https://issues.apache.org/jira/browse/SHINDIG-1766, the auto adjust of
dynamic-height and dynamic-width features was broken.
bq.
bq. The webkit height calculation is now the most reliable means of obtaining
the content height/width of the gadget in every browser I've tested, so I
cleaned that up for either height or width and moved it to the common feature.
bq.
bq.
bq. This addresses bug SHINDIG-1767.
bq. https://issues.apache.org/jira/browse/SHINDIG-1767
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-size.util/dynamic-size-util.js
1333997
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-size.util/feature.xml
1333997
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width.width/dynamic-width-width.js
1333997
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width/dynamic-width.js
1333997
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-height.height/dynamic-height-height.js
1333997
bq.
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/DynamicSizeDemoHTML5.xml
PRE-CREATION
bq.
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/DynamicSizeDemo.xml
1333997
bq.
bq. Diff: https://reviews.apache.org/r/5067/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Tested in IE 7,8,9 Chrome, FF using quirks and html5
bq.
bq.
bq. Thanks,
bq.
bq. Dan
bq.
bq.
> Gadgets using gadgets.window.adjustHeight are no longer adjusting to the
> correct height
> ---------------------------------------------------------------------------------------
>
> Key: SHINDIG-1767
> URL: https://issues.apache.org/jira/browse/SHINDIG-1767
> Project: Shindig
> Issue Type: Bug
> Affects Versions: 2.5.0
> Reporter: Ryan Baxter
> Assignee: Dan Dumont
>
> I am noticing that gadgets calling gadgets.window.adjustHeight are no longer
> agdjusting their height in the common container. For example try the ToDo
> gadget in the common container and you will notice the iframe will not grow
> to fit the whole gadget, however there will be a scroll bar allowing you to
> scroll.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
