[
https://issues.apache.org/jira/browse/SHINDIG-1771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13274614#comment-13274614
]
[email protected] commented on SHINDIG-1771:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5107/#review7842
-----------------------------------------------------------
Ship it!
LGTM
- Dan
On 2012-05-14 14:15:00, Stanton Sievers wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/5107/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-05-14 14:15:00)
bq.
bq.
bq. Review request for shindig.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. See the JIRA for the high-level description.
bq.
bq. My approach to doing this was to introduce a new test case in the
end-to-end tests. This way I can test with a real FeatureRegistry against the
real web app. I make a request to the JsServlet for all of the features, which
will run through the compiler processors. Because of the changes that went in
for https://issues.apache.org/jira/browse/SHINDIG-1770, we will return the
compile error and this will get printed as part of the JUnit assert failure,
pin-pointing the exact compile problem.
bq.
bq. Note that this does increase the time it takes to execute the EndToEndTest
on the scale of tens of seconds.
bq.
bq.
bq. This addresses bug SHINDIG-1771.
bq. https://issues.apache.org/jira/browse/SHINDIG-1771
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/test/java/org/apache/shindig/server/endtoend/AllJsFilter.java
PRE-CREATION
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/test/java/org/apache/shindig/server/endtoend/EndToEndServer.java
1337280
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/test/java/org/apache/shindig/server/endtoend/EndToEndTest.java
1337280
bq.
bq. Diff: https://reviews.apache.org/r/5107/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Introduced some JS errors and verified that the unit test failed.
Additionally verified the reason for the failure was readily available.
bq.
bq.
bq. Thanks,
bq.
bq. Stanton
bq.
bq.
> Closure compile all feature JavaScript as part of JUnit execution to ensure
> no JavaScript errors at build time
> --------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1771
> URL: https://issues.apache.org/jira/browse/SHINDIG-1771
> Project: Shindig
> Issue Type: Improvement
> Components: Java, Javascript
> Reporter: Stanton Sievers
> Assignee: Stanton Sievers
>
> At runtime, feature JavaScript is closure compiled at varying compilation
> levels depending on settings in shindig.properties and other debug flags. If
> there are compile errors, closure will return an error and this will
> eventually result in an error back to the client that requested the features.
>
> A better approach would be to compile each feature at build time as part of
> the JUnit execution and report errors there. This would allow any JavaScript
> errors to be caught at build time instead of runtime.
> To be clear, I'm not recommending a change to any of the runtime compilation
> behavior. That would stay exactly the same. This is simply extra testing we
> can do at build time to find errors.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
