[
https://issues.apache.org/jira/browse/SHINDIG-1963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13853308#comment-13853308
]
Ryan Baxter commented on SHINDIG-1963:
--------------------------------------
Review: https://reviews.apache.org/r/16401/
> Change content-type logic in TokenAuthorizationResponseHandler so
> application/x-www-form-urlencoded is the default
> -------------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1963
> URL: https://issues.apache.org/jira/browse/SHINDIG-1963
> Project: Shindig
> Issue Type: Improvement
> Affects Versions: 2.5.0, 2.5.0-update1
> Reporter: Ryan Baxter
> Assignee: Ryan Baxter
>
> There is logic in TokenAuthorizationResponseHandler that looks at the content
> type of the auth response and tried to get the access token and other
> properties from the response based on the response type. The logic was
> specific to certain providers, ie Google uses one content type, Facebook uses
> another. I ran into a problem today where the GitHub provider used a
> different content type but essentially was the same as Facebook. To simplify
> things I think we should default to handling the response as
> application/x-www-form-urlencoded unless they specify a different content
> type that we know how to handle (right now that is application/json).
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
