[
https://issues.apache.org/jira/browse/SHINDIG-1965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13905390#comment-13905390
]
Stanton Sievers commented on SHINDIG-1965:
------------------------------------------
New patch Committed revision 1569732
> iframe onload events firing more than once cause gadget iframe to empty
> -----------------------------------------------------------------------
>
> Key: SHINDIG-1965
> URL: https://issues.apache.org/jira/browse/SHINDIG-1965
> Project: Shindig
> Issue Type: Bug
> Affects Versions: 2.5.0-update1
> Reporter: Stanton Sievers
> Assignee: Stanton Sievers
> Fix For: 2.5.1
>
>
> In the case a gadget iframe is re-parented, the iframe's onload handler will
> fire again. This causes osapi.container.GadgetSite.prototype.onRender to
> call remove() on currentGadgetHolder_ because it is not null.
> This is easily reproducible in Apache Rave since it upgraded to Shindig
> 2.5.0-update1. Simply drag-and-drop a gadget on the page and its contents
> will disappear.
> I think GadgetSite.onRender should either guard against this scenario by
> checking to see if loadingGadgetHolder_ is set before clearing out
> currentGadgetHolder_ or we should remove the onload handler entirely from the
> iframe once it has fired once.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
