whikloj commented on issue #1339:
URL: https://github.com/apache/shiro/issues/1339#issuecomment-1975402756

   Hi @fpapon,
   
   I'm not sure I am understanding the use of the bom. 
   
   If in my main project pom I define (where `${shiro.version}` ==`2.0.0`):
   ```xml
   <dependencyManagement>
         <dependency>
           <groupId>org.apache.shiro</groupId>
           <artifactId>shiro-core</artifactId>
           <version>${shiro.version}</version>
           <classifier>jakarta</classifier>
         </dependency>
         <dependency>
           <groupId>org.apache.shiro</groupId>
           <artifactId>shiro-spring</artifactId>
           <version>${shiro.version}</version>
           <classifier>jakarta</classifier>
         </dependency>
         <dependency>
           <groupId>org.apache.shiro</groupId>
           <artifactId>shiro-web</artifactId>
           <version>${shiro.version}</version>
           <classifier>jakarta</classifier>
         </dependency>
         <dependency>
           <groupId>org.apache.shiro</groupId>
           <artifactId>shiro-bom</artifactId>
           <version>${shiro.version}</version>
           <type>pom</type>
         </dependency>
   </dependencyManagement>
   ```
   and in the actual auth module I add dependencies on:
   ```xml
      <dependency>
         <groupId>org.apache.shiro</groupId>
         <artifactId>shiro-spring</artifactId>
         <classifier>jakarta</classifier>
       </dependency>
       <dependency>
         <groupId>org.apache.shiro</groupId>
         <artifactId>shiro-web</artifactId>
         <classifier>jakarta</classifier>
       </dependency>
   ```
   
   Building the auth module, I end up with
   ```
   Dependency convergence error for javax.servlet.jsp:jsp-api:jar:2.2:provided 
paths to dependency are:
   +-org.fcrepo:fcrepo-auth-common:bundle:6.5.0-SNAPSHOT
     +-org.apache.shiro:shiro-spring:jar:jakarta:2.0.0:compile
       +-org.apache.shiro:shiro-web:jar:2.0.0:compile
         +-javax.servlet.jsp:jsp-api:jar:2.2:provided
   and
   +-org.fcrepo:fcrepo-auth-common:bundle:6.5.0-SNAPSHOT
     +-org.apache.shiro:shiro-web:jar:jakarta:2.0.0:compile
       +-javax.servlet.jsp:jsp-api:jar:2.2:provided
   and
   +-org.fcrepo:fcrepo-auth-common:bundle:6.5.0-SNAPSHOT
     +-org.apache.shiro:shiro-web:jar:jakarta:2.0.0:compile
       +-org.apache.taglibs:taglibs-standard-spec:jar:1.2.5:provided
         +-javax.servlet.jsp:jsp-api:jar:2.1:provided
   and
   +-org.fcrepo:fcrepo-auth-common:bundle:6.5.0-SNAPSHOT
     +-org.apache.shiro:shiro-web:jar:jakarta:2.0.0:compile
       +-org.apache.taglibs:taglibs-standard-impl:jar:1.2.5:provided
         +-javax.servlet.jsp:jsp-api:jar:2.1:provided
   
   [WARNING] 
   Dependency convergence error for javax.el:el-api:jar:2.2:provided paths to 
dependency are:
   +-org.fcrepo:fcrepo-auth-common:bundle:6.5.0-SNAPSHOT
     +-org.apache.shiro:shiro-web:jar:jakarta:2.0.0:compile
       +-javax.servlet.jsp:jsp-api:jar:2.2:provided
         +-javax.el:el-api:jar:2.2:provided
   and
   +-org.fcrepo:fcrepo-auth-common:bundle:6.5.0-SNAPSHOT
     +-org.apache.shiro:shiro-web:jar:jakarta:2.0.0:compile
       +-org.apache.taglibs:taglibs-standard-spec:jar:1.2.5:provided
         +-javax.el:el-api:jar:1.0:provided
   and
   +-org.fcrepo:fcrepo-auth-common:bundle:6.5.0-SNAPSHOT
     +-org.apache.shiro:shiro-web:jar:jakarta:2.0.0:compile
       +-org.apache.taglibs:taglibs-standard-impl:jar:1.2.5:provided
         +-javax.el:el-api:jar:1.0:provided
   ```
   
   Previously I had `shiro-core` and `shiro-spring` as dependencies, so if I 
switch back to those and remove `shiro-web` I end up in the same spot via 
`shiro-spring`
   
   ```
   Dependency convergence error for javax.servlet.jsp:jsp-api:jar:2.2:provided 
paths to dependency are:
   +-org.fcrepo:fcrepo-auth-common:bundle:6.5.0-SNAPSHOT
     +-org.apache.shiro:shiro-spring:jar:jakarta:2.0.0:compile
       +-org.apache.shiro:shiro-web:jar:2.0.0:compile
         +-javax.servlet.jsp:jsp-api:jar:2.2:provided
   and
   +-org.fcrepo:fcrepo-auth-common:bundle:6.5.0-SNAPSHOT
     +-org.apache.shiro:shiro-spring:jar:jakarta:2.0.0:compile
       +-org.apache.shiro:shiro-web:jar:2.0.0:compile
         +-org.apache.taglibs:taglibs-standard-spec:jar:1.2.5:provided
           +-javax.servlet.jsp:jsp-api:jar:2.1:provided
   and
   +-org.fcrepo:fcrepo-auth-common:bundle:6.5.0-SNAPSHOT
     +-org.apache.shiro:shiro-spring:jar:jakarta:2.0.0:compile
       +-org.apache.shiro:shiro-web:jar:2.0.0:compile
         +-org.apache.taglibs:taglibs-standard-impl:jar:1.2.5:provided
           +-javax.servlet.jsp:jsp-api:jar:2.1:provided
   
   [WARNING] 
   Dependency convergence error for javax.el:el-api:jar:2.2:provided paths to 
dependency are:
   +-org.fcrepo:fcrepo-auth-common:bundle:6.5.0-SNAPSHOT
     +-org.apache.shiro:shiro-spring:jar:jakarta:2.0.0:compile
       +-org.apache.shiro:shiro-web:jar:2.0.0:compile
         +-javax.servlet.jsp:jsp-api:jar:2.2:provided
           +-javax.el:el-api:jar:2.2:provided
   and
   +-org.fcrepo:fcrepo-auth-common:bundle:6.5.0-SNAPSHOT
     +-org.apache.shiro:shiro-spring:jar:jakarta:2.0.0:compile
       +-org.apache.shiro:shiro-web:jar:2.0.0:compile
         +-org.apache.taglibs:taglibs-standard-spec:jar:1.2.5:provided
           +-javax.el:el-api:jar:1.0:provided
   and
   +-org.fcrepo:fcrepo-auth-common:bundle:6.5.0-SNAPSHOT
     +-org.apache.shiro:shiro-spring:jar:jakarta:2.0.0:compile
       +-org.apache.shiro:shiro-web:jar:2.0.0:compile
         +-org.apache.taglibs:taglibs-standard-impl:jar:1.2.5:provided
           +-javax.el:el-api:jar:1.0:provided
   ```
   
   Which seems to say that the library has a dependency convergence error with 
itself. So I am sure I am missing something.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to