SIMJIYEON93 commented on issue #2069: URL: https://github.com/apache/shiro/issues/2069#issuecomment-2781293748
Thank you very much for the detailed review and thoughtful discussion! After carefully considering your feedback and reviewing the LDAP Realm codebase, I fully agree that allowing a `null` principal is consistent with the existing design and expected behavior. Since there was no actual failing use case, and maintaining API consistency is important, I agree that this change is unnecessary. I will close this PR accordingly. Thank you again for your time and guidance throughout the review process — it helped me better understand the importance of respecting existing project design and preserving API contracts. I truly appreciate the opportunity to learn from this experience and look forward to contributing again in the future! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
