[
https://issues.apache.org/jira/browse/SIS-560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Martin Desruisseaux updated SIS-560:
------------------------------------
Description:
{{org.apache.sis.storage.WritableFeatureSet}} currently contains the following
method:
{code:java}
boolean removeIf(Predicate<? super Feature> filter) throws DataStoreException;
{code}
The {{boolean}} return type may need to be removed. It currently exists for
compatibility with the {{Collection.removeIf(Predicate)}} method in case an
implementation chooses to implement {{WritableFeatureSet}} and
{{java.util.Collection}} in same time. But this is not recommended, and the
current method signature is a blocker for deferred method execution. Telling if
there is any feature to remove requires immediate execution of the filter,
while an implementation may want to wait in case the filtering can be combined
with other operations such as {{add(…)}} or {{replaceIf(…)}}.
was:
{{org.apache.sis.storage.WritableFeatureSet}} currently contains the following
method:
{code:java}
boolean removeIf(Predicate<? super Feature> filter) throws DataStoreException;
{code}
The {{boolean}} return type may need to be removed. It currently exists for
compatibility with the {{Collection.removeIf(Predicate)}} method in case an
implementation chooses to implements {{WritableFeatureSet}} and
{{java.util.Collection}} in same time. But this is not recommended, and the
current method signature is a blocker for deferred method execution. Telling if
there is any feature to remove requires immediate execution of the filter,
while an implementation may want to wait in case the filtering can be combined
with other operations such as {{add(…)}} or {{replaceIf(…)}}.
> Remove the boolean return value in WritableFeatureSet.removeIf(Predicate)
> -------------------------------------------------------------------------
>
> Key: SIS-560
> URL: https://issues.apache.org/jira/browse/SIS-560
> Project: Spatial Information Systems
> Issue Type: Improvement
> Components: Storage
> Affects Versions: 1.0, 1.1, 1.2
> Reporter: Martin Desruisseaux
> Assignee: Martin Desruisseaux
> Priority: Major
> Fix For: 1.4
>
>
> {{org.apache.sis.storage.WritableFeatureSet}} currently contains the
> following method:
> {code:java}
> boolean removeIf(Predicate<? super Feature> filter) throws DataStoreException;
> {code}
> The {{boolean}} return type may need to be removed. It currently exists for
> compatibility with the {{Collection.removeIf(Predicate)}} method in case an
> implementation chooses to implement {{WritableFeatureSet}} and
> {{java.util.Collection}} in same time. But this is not recommended, and the
> current method signature is a blocker for deferred method execution. Telling
> if there is any feature to remove requires immediate execution of the filter,
> while an implementation may want to wait in case the filtering can be
> combined with other operations such as {{add(…)}} or {{replaceIf(…)}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
