desruisseaux commented on code in PR #40:
URL: https://github.com/apache/sis/pull/40#discussion_r2792493750
##########
endorsed/src/org.apache.sis.cloud.aws/main/org/apache/sis/cloud/aws/s3/ClientFileSystemKey.java:
##########
@@ -0,0 +1,111 @@
+package org.apache.sis.cloud.aws.s3;
+
+import java.util.Objects;
+
+/**
+ * File System Key stored in {@link FileService#fileSystems},
+ *
+ * @author Quentin Bialota (Geomatys)
+ */
+public class ClientFileSystemKey {
+
+ /**
+ * The S3 access key
+ */
+ private final String accessKey;
+
+ /**
+ * The S3 host (if not stored on Amazon AWS Infrastructure)
+ */
+ private final String host;
+
+ /**
+ * The S3 port (if not stored on Amazon AWS Infrastructure)
+ */
+ private final Integer port;
+
+ /**
+ * Is the S3 HTTP Protocol secure (if not stored on Amazon AWS
Infrastructure)
+ */
+ private final boolean isHttps;
+
+ /**
+ * Creates a new file system key for the {@link FileService} with access
key, host, port and protocol (secure or not secure)
+ *
+ * @param accessKey the S3 access key for this file system.
+ * @param host the host or {@code null} for aws request
+ * @param port the port or {@code -1} for aws request
Review Comment:
The field and the argument are a potentially null `Integer`, but this
Javadoc said that -1 is used for meaning AWS request. We should choose one or
the other. In `java.net.URL`, Java use -1 for saying that the port is not set.
I suggest to follow the same convention: replace all `Integer port` by `int
port` with the convention that -1 means "not set".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
