desruisseaux commented on code in PR #40:
URL: https://github.com/apache/sis/pull/40#discussion_r2792603040
##########
endorsed/src/org.apache.sis.cloud.aws/main/org/apache/sis/cloud/aws/s3/FileService.java:
##########
@@ -289,14 +432,9 @@ public FileSystem getFileSystem(final URI uri) {
@Override
public Path getPath(final URI uri) {
final String accessKey = getAccessKey(uri);
- final ClientFileSystem fs;
- if (accessKey == null) {
- fs = getDefaultFileSystem();
- } else {
- // TODO: we may need a way to get password here.
- fs = fileSystems.computeIfAbsent(accessKey, (key) -> new
ClientFileSystem(FileService.this, null, key, null, null));
- }
String host = uri.getHost();
+ final int port = uri.getPort();
Review Comment:
Potential `NullPointerException` here, unless the "`Integer` with null"
convention is replaced by a "`int` with -1" convention as proposed in other
comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
