dsmiley commented on pull request #18: URL: https://github.com/apache/solr/pull/18#issuecomment-799588251
> I disagree with this. Maybe you're right, but we can leave the comment in until we've had more time to think this through. Then let's discuss now. I reviewed each one of them to hypothesize if it's plausible there is an optimization opportunity. For two, I thought maybe, so I proposed more specific code comments than those general comments. Let's not commit "quick fix" comments; let's be more specific. In the other places, I felt the code was already doing what it can -- that there didn't seem to be a plausible way to avoid the BytesRef lookup. Do you disagree? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
