MarcusSorealheis commented on a change in pull request #42:
URL: https://github.com/apache/solr/pull/42#discussion_r604457028



##########
File path: solr/webapp/web/js/angular/services.js
##########
@@ -254,6 +254,17 @@ solrAdminServices.factory('System',
        get: {method: "GET"}
      })
 }])
+.factory('SchemaDesigner',
+   ['$resource', function($resource) {
+     return $resource('/api/schema-designer/:path', {wt: 'json', path: 
'@path', _:Date.now()}, {
+       get: {method: "GET"},
+       post: {method: "POST"},
+       put: {method: "PUT"},
+       postXml: {headers: {'Content-type': 'text/xml'}, method: "POST"},
+       postCsv: {headers: {'Content-type': 'application/csv'}, method: "POST"},
+       upload: {method: "POST", transformRequest: angular.identity, headers: 
{'Content-Type': undefined} }

Review comment:
       That makes sense. I am still testing out the tool and profiling the 
network requests. I had not gotten to this request in the real world, though it 
was on my list. This was my reaction when I was simply reading the code.
   
   Awesome job. Important feature.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to