[
https://issues.apache.org/jira/browse/SOLR-15322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17315871#comment-17315871
]
Chris M. Hostetter commented on SOLR-15322:
-------------------------------------------
This idea started in SOLR-15129, and then I borrowed that work in SOLR-15250
(which is an alternative/competitive idea to achieve the same goal) and now
realize that regardless of how/if we decide we want to build "official" docker
images from our solr.tgz artifacts, it just makes sense for solr.tgz to include
the docker scripts.
So i spun this issue off – we should just "make this happen" so it's ready, and
done, and usable for whatever other more complex things wind up needing to be
done for the parent issue....
----
In SOLR-15250 i mentioned in some nocommit gradle comments that I am not a fan
of where Houston put the scripts in his SOLR-15129 work...
{noformat}
+ // nocommit: This comes from SOLR-15129, but causes a
solr-9.0.0-SNAPSHOT/docker dir to be created in the solr.tgz
+ // nocommit: which directly contains the scripts....
+ // nocommit: - This feels wrong & confusing
+ // nocommit: - I feel like these scripts should wind up somewhere like
solr-9.0.0-SNAPSHOT/server/scripts/docker-scripts
+ // nocommit: and then the Dockerfile can move / symlink that dir as
needed
+ // nocommit: - At the very least: we should use a name like
solr-9.0.0-SNAPSHOT/docker-scripts instead.
+ // nocommit: - Since we aren't including the Dockerfile in the tgz,
having a top level 'docker' dir in our tgz
+ // nocommit: release that contains a bunch of scripts w/o README or
Dockerfile will be confusing to users who
+ // nocommit: download the solr.tgz artifact
+ from(configurations.docker, {
+ exclude "Dockerfile"
+ into "docker"
+ })
{noformat}
[~houstonputman] replied...
{quote}Perfectly happy to move the docker-scripts to a different directory in
the TGZ, but I would prefer for them to not live under {{server/}}
{quote}
Houston: can you elaborate on why you don't like them living under server?
Given the existing layout of the solr.tgz artifact, the {{server/scripts}}
directory seems like the ideal place for them: It is the directory that
contains everything related to running solr as a server, and it already has an
existing directory for "scripts"
My main concern is not to "pollute" the top level directory with too many
distractions for people who download solr -- particularly since many/most
people who do so aren't going care about anything docker specific (if they did,
they would probably just be using {{docker run ...} not downloading a tgz file)
> include all docker context pre-reqs (notably docker scripts) in released
> solr.tgz
> ---------------------------------------------------------------------------------
>
> Key: SOLR-15322
> URL: https://issues.apache.org/jira/browse/SOLR-15322
> Project: Solr
> Issue Type: Sub-task
> Reporter: Chris M. Hostetter
> Priority: Major
>
> in the 8.x docker-solr world, all of the scripts specific to the docker image
> lived in the 'docker-solr' repo and were completely disjoint from solr.
> in 9x, these scripts currently live in the solr/solr/docker/scripts directory
> of the solr.git repo, and the build.gradle file copies them into the docker
> context.
> we should move towards including these scripts -- and any other solr specific
> docker image pre-requisites -- into the "solr-X.Y.Z.tgz" release artifact, so
> that it contains everything necessary for building a solr docker image.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
