dsmiley commented on a change in pull request #68:
URL: https://github.com/apache/solr/pull/68#discussion_r612740578
##########
File path:
solr/contrib/blob-directory/src/java/org/apache/solr/blob/BlobDirectoryFactory.java
##########
@@ -20,31 +20,49 @@
import java.io.File;
import java.io.IOException;
import java.lang.invoke.MethodHandles;
+import java.net.URI;
+import java.util.Arrays;
import java.util.List;
import java.util.Locale;
import java.util.regex.Pattern;
+import java.util.stream.Collectors;
import org.apache.commons.io.FileUtils;
import org.apache.lucene.store.*;
import org.apache.solr.common.SolrException;
+import org.apache.solr.common.params.CoreAdminParams;
import org.apache.solr.common.params.SolrParams;
import org.apache.solr.common.util.IOUtils;
import org.apache.solr.common.util.NamedList;
import org.apache.solr.core.CachingDirectoryFactory;
import org.apache.solr.core.CoreContainer;
import org.apache.solr.core.CoreDescriptor;
import org.apache.solr.core.DirectoryFactory;
+import org.apache.solr.core.backup.repository.BackupRepository;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
public class BlobDirectoryFactory extends CachingDirectoryFactory {
private static final Logger log =
LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
+ /**
+ * Default maximum number of threads that push files concurrently to the
backup repository.
+ */
+ private static final int DEFAULT_MAX_THREADS = 20;
+
+ /**
+ * Default size of the buffer used to transfer input-output stream to the
{@link BackupRepository}, in bytes.
+ * The appropriate size depends on the {@link BackupRepository}.
+ * There is one buffer per thread.
+ */
+ public static final int DEFAULT_STREAM_BUFFER_SIZE = 32_768;
+
private static final Pattern INDEX_NAME_PATTERN =
Pattern.compile("index(?:\\.[0-9]{17})?");
private String localRootPath;
- private BlobStore blobStore;
+ private BackupRepository backupRepository;
Review comment:
I see "BlobStore" in some places that could be simply "Repo" or
"Repository"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
