bruno-roustant commented on a change in pull request #47:
URL: https://github.com/apache/solr/pull/47#discussion_r618272385
##########
File path: solr/core/src/test/org/apache/solr/cloud/UnloadDistributedZkTest.java
##########
@@ -65,7 +67,11 @@ protected String getSolrXml() {
@Test
public void test() throws Exception {
- jettys.forEach(j ->
j.getCoreContainer().getAllowPaths().add(Path.of("_ALL_"))); // Allow
non-standard core instance path
+ jettys.forEach(j -> {
+ Set<Path> allowPath = j.getCoreContainer().getAllowPaths();
+ allowPath.clear();
+ allowPath.addAll(SolrPaths.ALL_PATHS); // Allow non-standard core
instance path
Review comment:
I was also surprised to see that. There are many tests (and only tests)
that use this mutablity to add test dirs in the allowed list. I don't like that
very much, but I don't think this should be changed in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
