[
https://issues.apache.org/jira/browse/SOLR-15067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17330443#comment-17330443
]
David Smiley commented on SOLR-15067:
-------------------------------------
Glad to see you are willing to help!
I suppose the implementation method is so simple (that you referenced in
BlockJoinParentQParser) that it's okay to simply duplicate it into
ChildDocTransformerFactory. If that doesn't sit well with you, it could
reasonably be added to SolrIndexSearcher.
Manual testing should be fine... you might have to use a debugger to ascertain
it's working as designed. Obviously use both the child doc transformer and
parent block join query, maybe even in the same query.
Just curious; how did you come upon this issue? Did you notice this
performance problem?
> Child doc transformer should use the perSegFilter cache
> -------------------------------------------------------
>
> Key: SOLR-15067
> URL: https://issues.apache.org/jira/browse/SOLR-15067
> Project: Solr
> Issue Type: Improvement
> Reporter: David Smiley
> Priority: Major
> Labels: newdev
>
> The ChildDocTransformerFactory creates a QueryBitSetProducer every time.
> These are heavy to compute; they should be cached.
> BlockJoinParentQParserPlugin does this correctly, using the "perSegFilter"
> named Solr cache. They should both do the same. To avoid duplication of
> logic, consider creating a new class named something like
> PerSegFilterCacheManager, or maybe manage directly on SolrIndexSearcher
> (alas; SIS is huge).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
